busybox-w32/coreutils/tsort.c, branch long_pathsA mirror of https://github.com/rmyorston/busybox-w32.git
https://git.lua4.win/busybox-w32/atom?h=long_paths2023-08-31T07:41:53+00:00tsort: avoid use-after-free2023-08-31T07:41:53+00:00Ron Yorstonrmy@pobox.com2023-08-22T08:38:03+00:00urn:sha1:2cc9d436e80632157b99e18d413a62b2d44d321a
When the input data contained a cycle it was possible for tsort to
attempt to access freed nodes. This sometimes resulted in the
test case 'echo a b b a | tsort' crashing.
Don't free nodes when they're removed from the graph.
function old new delta
tsort_main 621 596 -25
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-25) Total: -25 bytes
Signed-off-by: Ron Yorston <rmy@pobox.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Update applet size estimates2023-07-10T15:25:21+00:00Denys Vlasenkovda.linux@googlemail.com2023-07-10T15:25:21+00:00urn:sha1:5353df91cba7b397b9407701681708d0a1518df6
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
tsort: new applet2022-05-02T12:25:36+00:00David Leonardd+busybox@adaptive-enterprises.com2022-02-20T04:29:45+00:00urn:sha1:4642cf5b388bf60f6bea67ce3a5031d24bccd48a
function old new delta
tsort_main - 578 +578
.rodata 104884 104906 +22
applet_names 2759 2765 +6
applet_main 1596 1600 +4
packed_usage 34290 34288 -2
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 3/1 up/down: 610/-2) Total: 608 bytes
Signed-off-by: David Leonard <d+busybox@adaptive-enterprises.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>