busybox-w32/findutils, branch waitfor

xargs: limit number of processes to 64

2026-07-16T12:58:37+00:00

Upstream limits the number of processes invoked with the '-P 0' option to 100. On Windows the limit was set to MAXIMUM_WAIT_OBJECTS, as that's the most WaitForMultipleObjects() can handle. Apply the same limit to user-supplied '-P' values. This avoids the need to loop over blocks of MAXIMUM_WAIT_OBJECTS. "64 processes ought to be enough for anyone." Saves 64-80 bytes. Signed-off-by: Ron Yorston

Fix the flags for stat (again) (#601)

2026-06-22T10:36:43+00:00

* Revert "find: reset stat(2) flags before terminating" This reverts commit 228ee18fbe8cf408440e7bbe91db4ef201312983. * test: fix flags for stat with NOFORK test is a NOFORK applet, so the flags under mingw_stat may not have been reset before calling it. We have it so it also restores the flags after, since it could be called in the middle of another applet. This also needed a way to retrieve the flags, so they are just done through the return value. * Add comments about not having to restore flags Just for future reference * lineedit: use new flag restoring * win32: simplify mingw_access calling Since we now have a way to get the previous flags, mingw_access can be changed to ignore any stat flags * stat: comments from PR Adds 32 bytes.

find: reset stat(2) flags before terminating

2026-06-19T18:13:54+00:00

Commit a717c6844 (find: skip check for execute when not needed) didn't reset stat(2) to its default behaviour (at my insistence). This was incorrect. The '-exec cmd {} +' action calls a nofork 'cmd' directly without spawning a new process. If 'cmd' calls 'stat(2)' it won't be in its default state which can affect the result. Reintroduce the code to reset 'stat(2)'. Adds 16 bytes. (GitHub PR #600) Signed-off-by: Ron Yorston

find: skip check for execute when not needed

2026-06-19T15:15:35+00:00

See previous commits: 1fb1a65064748a54fba4bf4b5e8700f8e61f003f 6a7ccb6ca3bd9b661760879478ecf0d5f6112fc3 My testing shows a speedup of around 30%, but that will vary with whether files are cached. Test inside busybox repository with files cached: Command | before | after find >/dev/null | 0.83s | 0.56s find -executable >/dev/null | 1.56s | 1.35s

win32: fix compilation with FEATURE_SH_NOFORK disabled

2024-12-31T08:21:12+00:00

Compiling with FEATURE_SH_NOFORK disabled resulted in an error and a warning. Fixing these doesn't change the default build.

xargs: allow for quotes in commands on Windows

2024-12-30T13:07:47+00:00

When xargs limited the length of the command lines it generated it didn't allow for the quoting Windows spawn() introduces. Properly account for any additional characters required when a command is spawned on Windows. If the command is a NOFORK applet this isn't necessary. Adds 384-464 bytes.

win32: work around problem with stderr in MSVCRT

2024-09-30T15:08:42+00:00

Try to run a non-existent command with standard error closed: xyz 2>&- In recent versions of busybox-w32 this resulted in problems with moving through history (either using up/down keys or ctrl-r) and tab completion. In all cases the order of the prompt and the command were reversed. Bisection showed the problem was first seen in PRE-5396 which merged some commits from upstream, including fd47f0567 (lineedit: print prompt and editing operations to stderr). This (eventually) called to mind a previous problem with stderr in xargs which was fixed by commit f192e6539 (xargs: fix 'xargs -sNUM' tests). In both cases it seemed that mixing calls to bb_putchar_stderr() and fprintf(stderr, ...) was at fault. The former uses a file descriptor while the latter uses a stream. It was almost as if the stream was buffered. - The problem with xargs affected 32-bit and 64-bit builds with MSVCRT. - The problem with '2>&-' only affected 32-bit builds with MSVCRT. - Neither problem was present with UCRT builds. As a workaround change bb_putchar_stderr() to use the stderr stream in builds for MSVCRT. Saves 16 bytes in the 32-bit build. (GitHub issue #460)

Merge branch 'busybox' into merge

2023-07-13T07:06:26+00:00

Update applet size estimates

2023-07-10T15:25:21+00:00

Signed-off-by: Denys Vlasenko

libbb: code shrink: introduce and use [_]exit_FAILURE()

2023-06-15T09:55:56+00:00

function old new delta exit_FAILURE - 7 +7 _exit_FAILURE - 7 +7 run 198 199 +1 restore_state_and_exit 114 115 +1 xbsd_write_bootstrap 399 397 -2 vfork_compressor 209 207 -2 sig_handler 12 10 -2 serial_ctl 154 152 -2 parse_args 1169 1167 -2 onintr 21 19 -2 make_new_session 493 491 -2 login_main 988 986 -2 gotsig 35 33 -2 do_iplink 1315 1313 -2 addgroup_main 397 395 -2 inetd_main 1911 1908 -3 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/12 up/down: 16/-25) Total: -9 bytes Signed-off-by: Denys Vlasenko