busybox-w32/libbb/get_line_from_file.c, branch cron_changes

win32: don't assume console CP equals OEM CP

2023-06-28T14:10:49+00:00

Previously, console input was converted to the ANSI codepage using OemToChar[Buff], and ANSI to console conversion used CharToOem[Buff]. However, while typically true by default, it's not guaranteed that the console CP is the same as the OEM CP. Now the code uses the console input/output CP as appropriate instead of the OEM CP. It uses full wide-char conversion code, which was previously limited to FEATURE_EURO, and now may be used also otherwise. While at it, the code now bypasses the conversion altogether if the src/dst CPs happen to be identical - which can definitely happen. Other than saving some CPU cycles, this also happens to fix an issue with the UTF8 manifest (in both input and output), because apparently the Oem/Char conversion APIs fail to convert one char at a time (which is not a complete UTF8 codepoint sequence) even if both the OEM and the ANSI CPs are UTF8 (as is the case when using UTF8 manifest). Conversion is also skipped: - if the converted output would be longer than the input; - if the input length is 1 and the input is multi-byte.

libbb: fix CRLF handling

2023-01-31T08:22:10+00:00

Ensure a trailing CR is only removed if it precedes a LF. The two cases at issue are intended to read complete lines and remove the line terminator. In the normal case a trailing LF will be present so removing the CR unconditionally worked. However, if the last line of a file was missing its LF or if a NUL was detected (in the case of xmalloc_fgetline()) the CR might have been removed without justification.

libbb: speed up bb_get_chunk_from_file()

2022-12-30T20:56:56+00:00

Use _getc_nolock() in bb_get_chunk_from_file() and perform code page translation on the resulting string. This speeds up grep by another factor of two. (GitHub issue #278)

Merge branch 'busybox' into merge

2018-09-10T13:59:33+00:00

libbb: in xmalloc_fgets(), use size_t for bb_get_chunk_from_file()

2018-09-02T16:48:09+00:00

Signed-off-by: Denys Vlasenko

Revert "libbb: remove unnecessary variable in xmalloc_fgets"

2018-09-02T16:35:29+00:00

The variable is in fact necessary. commit 2da9724b56169f00bd7fb6b9a11c9409a7620981 Author: Quentin Rameau Date: Sun Apr 1 17:05:35 2018 +0200 libbb: remove unnecessary variable in xmalloc_fgets Signed-off-by: Denys Vlasenko

Merge branch 'busybox' into merge

2018-04-02T08:24:14+00:00

libbb: new function bb_die_memory_exhausted

2018-04-01T17:59:37+00:00

function old new delta bb_die_memory_exhausted - 10 +10 xstrdup 28 23 -5 xsetenv 27 22 -5 xrealloc 32 27 -5 xputenv 22 17 -5 xmalloc 30 25 -5 xfdopen_helper 40 35 -5 xasprintf 44 39 -5 wget_main 2387 2382 -5 open_socket 54 49 -5 glob_brace 419 414 -5 bb_get_chunk_from_file 146 141 -5 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/11 up/down: 10/-55) Total: -45 bytes Signed-off-by: Denys Vlasenko

sed: prevent overflow of length from bb_get_chunk_from_file

2018-04-01T17:51:14+00:00

This fragment did not work right: temp = bb_get_chunk_from_file(fp, &len); if (temp) { /* len > 0 here, it's ok to do temp[len-1] */ char c = temp[len-1]; With "int len" _sign-extending_, temp[len-1] can refer to a wrong location if len > 0x7fffffff. Signed-off-by: Quentin Rameau Signed-off-by: Denys Vlasenko

libbb: remove unnecessary variable in xmalloc_fgets

2018-04-01T17:45:36+00:00

Signed-off-by: Quentin Rameau Signed-off-by: Denys Vlasenko