busybox-w32/libbb/getpty.c, branch cron_changes

telnetd: if vfork in make_new_session() fails, do close socket.

2026-02-23T23:03:20+00:00

function old new delta telnetd_main 372 385 +13 make_new_session 550 552 +2 xgetpty 81 78 -3 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 15/-3) Total: 12 bytes Signed-off-by: Denys Vlasenko

libbb: reduce the overhead of single parameter bb_error_msg() calls

2019-07-02T09:35:03+00:00

Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower overhead call to bb_perror_msg() when only a string was being printed with no parameters. This saves space for some CPU architectures because it avoids the overhead of a call to a variadic function. However there has never been a simple version of bb_error_msg(), and since 2007 many new calls to bb_perror_msg() have been added that only take a single parameter and so could have been using bb_simple_perror_message(). This changeset introduces 'simple' versions of bb_info_msg(), bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and bb_herror_msg_and_die(), and replaces all calls that only take a single parameter, or use something like ("%s", arg), with calls to the corresponding 'simple' version. Since it is likely that single parameter calls to the variadic functions may be accidentally reintroduced in the future a new debugging config option WARN_SIMPLE_MSG has been introduced. This uses some macro magic which will cause any such calls to generate a warning, but this is turned off by default to avoid use of the unpleasant macros in normal circumstances. This is a large changeset due to the number of calls that have been replaced. The only files that contain changes other than simple substitution of function calls are libbb.h, libbb/herror_msg.c, libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c, networking/udhcp/common.h and util-linux/mdev.c additonal macros have been added for logging so that single parameter and multiple parameter logging variants exist. The amount of space saved varies considerably by architecture, and was found to be as follows (for 'defconfig' using GCC 7.4): Arm: -92 bytes MIPS: -52 bytes PPC: -1836 bytes x86_64: -938 bytes Note that for the MIPS architecture only an exception had to be made disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h) because it made these files larger on MIPS. Signed-off-by: James Byrne Signed-off-by: Denys Vlasenko

whitespace and comment format fixes, no code changes

2017-10-05T12:40:24+00:00

Signed-off-by: Denys Vlasenko

script: make it work even if fd 0 is closed

2014-03-16T11:34:53+00:00

Testcase: script -q -c "echo hey" /dev/null 0>&- Signed-off-by: Denys Vlasenko

Fixes for warnings in FreeBSD build

2011-08-28T03:31:49+00:00

Signed-off-by: Denys Vlasenko

FreeBSD compat

2011-01-24T16:04:59+00:00

Signed-off-by: Chris Rees Signed-off-by: Denys Vlasenko

*: make GNU licensing statement forms more regular

2010-08-16T18:14:46+00:00

This change retains "or later" state! No licensing _changes_ here, only form is adjusted (article, space between "GPL" and "v2" and so on). Signed-off-by: Denys Vlasenko

libbb: use ptsname_r, it's smaller

2008-08-17T12:47:19+00:00

function old new delta xgetpty 91 81 -10 ptsname 33 - -33 text data bss dec hex filename 793828 592 6692 801112 c3958 busybox_old 793796 592 6660 801048 c3918 busybox_unstripped

*: introduce and use FAST_FUNC: regparm on i386, otherwise no-on

2008-06-27T02:52:20+00:00

text data bss dec hex filename 808035 611 6868 815514 c719a busybox_old 804472 611 6868 811951 c63af busybox_unstripped

- Rename getpty() to xgetpty() and adjust callers.

2008-05-19T08:18:50+00:00

- Rewrite kbd_mode and setconsole - Introduce and use console_make_active() and xopen_xwrite_close() - honour buffer-reservation method as set by the user (dumpkmap, loadkmap) - shrink rtcwake and some console-tools Saves about 270 Bytes