busybox-w32/libbb/loop.c, branch cron_changes

libbb/loop: fix existence check for LOOP_CONFIGURE ioctl

2026-01-26T04:43:17+00:00

The LOOP_CONFIGURE ioctl is supported in 5.8 kernels and up. To have backwards compatibility there is a config option CONFIG_TRY_LOOP_CONFIGURE that will check if the ioctl exists and if not fall back to old way of configuring loop devices. Normally errno will be set to EINVAL when this ioctl does not exist. However, when kernel config CONFIG_COMPAT is enabled, then compat_ioctl is called. In that case -ENOIOCTLCMD is returned by loop device driver and generic ioctl wrapper will set errno to ENOTTY. Because busybox does not expect this it will fail to mount loop devices in this case. This patch fixes the check for the existence of the ioctl LOOP_CONFIGURE by checking if errno is one of both: EINVAL or ENOTTY. function old new delta set_loop 809 821 +12 Signed-off-by: Wouter Franken Signed-off-by: Denys Vlasenko

libbb/loop: fix compile failure (name collision)

2023-01-02T16:03:44+00:00

Signed-off-by: Denys Vlasenko

libbb: shrink del_loop()

2022-12-13T15:00:00+00:00

function old new delta del_loop 52 49 -3 Signed-off-by: Denys Vlasenko

loop: restore the correct return vaule of set_loop()

2022-12-13T14:52:52+00:00

It is only used by mount's error path, though... Signed-off-by: Denys Vlasenko

loop: optionally use ioctl(LOOP_CONFIGURE) to set up loopdevs

2022-12-13T14:21:28+00:00

LOOP_CONFIGURE is added to Linux 5.8 function old new delta NO_LOOP_CONFIGURE (old code): set_loop 784 782 -2 LOOP_CONFIGURE: set_loop 784 653 -131 TRY_LOOP_CONFIGURE: set_loop 784 811 +27 Based on a patch by Xiaoming Ni Signed-off-by: Denys Vlasenko

loop: refactor: extract subfunction set_loopdev_params()

2022-12-13T13:26:20+00:00

Extract subfunction set_loop_info() from set_loop() function old new delta set_loop 760 784 +24 Signed-off-by: Xiaoming Ni Signed-off-by: Denys Vlasenko

loop: simplify code of LOOP_SET_FD failure

2022-12-12T18:03:06+00:00

function old new delta set_loop 790 760 -30 Signed-off-by: Xiaoming Ni Signed-off-by: Denys Vlasenko

loop: refactor: extract subfunction get_next_free_loop()

2022-12-12T17:57:09+00:00

Extract subfunction get_next_free_loop() from set_loop() Also fix miss free(try) when stat(try) and mknod fail function old new delta set_loop 807 790 -17 Fixes: 3448914e8cc5 ("mount,losetup: use /dev/loop-control is it exists") Signed-off-by: Xiaoming Ni Signed-off-by: Denys Vlasenko

loop: fix a race when a free loop device is snatched

2022-11-15T13:54:05+00:00

When /dev/loop-control exists and *device is empty, the mount may fail if a concurrent mount is running. function old new delta set_loop 809 807 -2 Signed-off-by: Xiaoming Ni Signed-off-by: Denys Vlasenko

mount: if we race with other loop mount, we forget to close loop dev

2020-12-17T22:38:06+00:00

Signed-off-by: Denys Vlasenko