busybox-w32/libbb, branch ucrt_hack

win32: move UCRT hack to process.c

2021-11-04T12:27:45+00:00

Only apply the UCRT hack if we're about to call spawnve() with a non-NULL environment pointer. Add the pid of the process to the name of the environment variable to provide greater assurance that the environment will be changed.

win32: UCRT environment hack

2021-11-01T12:27:58+00:00

Commit 5b48ca53b (win32: pass NULL to spawnve, not environ) was an attempt to fix a problem seen in busybox-w32 built against the UCRT runtime. It was effective for applets like 'time' which pass an unmodified environment to their children but not the shell which needs to alter the environment to include exported shell variables. A peculiar feature of the problem was that it only manifested when the BusyBox binary was run by GNU make. Like the shell, make needs to modify the environment passed to its children. GNU make therefore creates a new environment block which is passed to CreateProcess. As was the case with the previous commit passing a NULL pointer instead made the problem go away. It was also noted that failures only occurred when the child program was built against UCRT. Whether make was linked against UCRT or MVSCRT made no difference. It appears that programs linked against UCRT are unable to handle their parent passing a non-default environment block. It also appears that setting an environment variable early in program execution perturbs the environment block sufficiently to avoid the problem. YMMV. (GitHub issue #234)

realpath: improved support for Windows paths

2021-10-13T15:44:45+00:00

Upstream commit 94eb1c4dc (libbb: better coreutils compatibility for realpath) made some changes to xmalloc_realpath_coreutils(). This now needs to be updated to handle Windows paths. - Expose the macro is_unc_path() and part of the recent change to bb_get_last_path_component_nostrip() as a separate funtion, get_last_slash(); - Convert a couple of errors relating to network filesystems to ENOENT; - Adjust xmalloc_realpath_coreutils() to handle Windows directory separators, relative paths and UNC paths.

Merge branch 'busybox' into merge

2021-10-13T13:37:51+00:00

win32: fix bb_get_last_path_component_nostrip()

2021-10-13T13:21:18+00:00

Finding the last component of a path didn't properly handle a mixture of slashes and backslashes, paths relative to another drive or bare UNC paths. The following were incorrect: $ basename /dir\\file dir\file $ basename c:file c:file $ basename //HOST/share share With this patch the results are now: $ basename /dir\\file file $ basename c:file file $ basename //HOST/share //HOST/share

win32: rename is_absolute_path()

2021-10-12T12:43:15+00:00

As the comment pointed out is_absolute_path() was misnamed. Rename it to is_relative_path() and change the sense of all tests.

config system: move some options closer to relevalnt tool subdirectories

2021-10-12T11:23:29+00:00

Signed-off-by: Denys Vlasenko

shell: do not read user database for every prompt - only for those which need it

2021-10-11T21:08:31+00:00

function old new delta get_user_strings - 52 +52 get_homedir_or_NULL - 23 +23 parse_and_put_prompt 823 838 +15 null_str 1 - -1 complete_cmd_dir_file 814 812 -2 deinit_S 51 42 -9 read_line_input 3059 3015 -44 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 1/3 up/down: 90/-56) Total: 34 bytes Signed-off-by: Denys Vlasenko

shell: fix script's comm field if ENABLE_FEATURE_PREFER_APPLETS=y

2021-10-11T16:44:00+00:00

function old new delta re_execed_comm - 46 +46 main 72 86 +14 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/0 up/down: 60/0) Total: 60 bytes Signed-off-by: Denys Vlasenko

*: add NOINLINEs where code noticeably shrinks

2021-10-10T11:50:53+00:00

function old new delta display 85 1463 +1378 -73 bytes select_and_cluster - 1088 +1088 -139 bytes parse_reply - 979 +979 -109 bytes zbc_num_sqrt - 632 +632 -191 bytes show_bridge_port - 585 +585 -56 bytes sp_256_proj_point_add_8 - 576 +576 -45 bytes encode_then_append_var_plusminus - 554 +554 -118 bytes read_mode_db - 537 +537 -47 bytes fbset_main 1331 747 -584 sp_256_ecc_mulmod_8 1157 536 -621 brctl_main 2189 1548 -641 expand_one_var 2544 1872 -672 zxc_vm_process 6412 5589 -823 send_queries 1813 725 -1088 recv_and_process_peer_pkt 2245 1018 -1227 bb_dump_dump 1531 80 -1451 ------------------------------------------------------------------------------ (add/remove: 7/0 grow/shrink: 1/8 up/down: 6329/-7107) Total: -778 bytes Signed-off-by: Denys Vlasenko