busybox-w32/loginutils/passwd.c, branch join2

Update applet size estimates

2023-07-10T15:25:21+00:00

Signed-off-by: Denys Vlasenko

help text tweaks

2020-12-13T18:04:19+00:00

function old new delta packed_usage 33547 33545 -2 Signed-off-by: Denys Vlasenko

libbb: bb_do_delay(3) -> pause_after_failed_login(), and stop looping there

2020-11-29T10:32:48+00:00

function old new delta pause_after_failed_login - 9 +9 vlock_main 358 353 -5 sulogin_main 252 247 -5 su_main 484 479 -5 passwd_main 936 931 -5 login_main 967 962 -5 bb_do_delay 68 - -68 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 0/5 up/down: 9/-93) Total: -84 bytes Signed-off-by: Denys Vlasenko

Optionally re-introduce bb_info_msg()

2019-04-30T08:51:27+00:00

Between Busybox 1.24.2 and 1.25.0 the bb_info_msg() function was eliminated and calls to it changed to be bb_error_msg(). The downside of this is that daemons now log all messages to syslog at the LOG_ERR level which makes it hard to filter errors from informational messages. This change optionally re-introduces bb_info_msg(), controlled by a new option FEATURE_SYSLOG_INFO, restores all the calls to bb_info_msg() that were removed (only in applets that set logmode to LOGMODE_SYSLOG or LOGMODE_BOTH), and also changes informational messages in ifplugd and ntpd. The code size change of this is as follows (using 'defconfig' on x86_64 with gcc 7.3.0-27ubuntu1~18.04) function old new delta bb_info_msg - 182 +182 bb_vinfo_msg - 27 +27 static.log7 194 198 +4 log8 190 191 +1 log5 190 191 +1 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 3/0 up/down: 215/-45) Total: 170 bytes If you don't care about everything being logged at LOG_ERR level then when FEATURE_SYSLOG_INFO is disabled Busybox actually gets smaller: function old new delta static.log7 194 200 +6 log8 190 193 +3 log5 190 193 +3 syslog_level 1 - -1 bb_verror_msg 583 581 -2 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 3/1 up/down: 12/-48) Total: -36 bytes Signed-off-by: James Byrne Signed-off-by: Denys Vlasenko

passwd: initialize pointers correctly

2019-01-08T15:32:25+00:00

Fix for running passwd as root (or sudo passwd $USER). Crashed on call to free(orig) during cleanup. Fix regression from commit 17058a06c4333fc0c492c168c8a971ebd0fd5a5a Root user never changes the orig pointer, so when cleaning up, passwd tried to free orig=(char*)"" Example: sudo passwd $USER Changing password for xxx New password: Bad password: too short Retype password: Passwords don't match free(): invalid pointer Aborted function old new delta passwd_main 958 961 +3 Signed-off-by: Einar Jón Signed-off-by: Denys Vlasenko

libbb.h: always include sys/resource.h

2018-04-08T15:23:27+00:00

Signed-off-by: Denys Vlasenko

libbb: switch bb_ask_noecho() to "mallocing" string return API

2018-04-07T13:50:30+00:00

function old new delta bb_ask_noecho 313 330 +17 get_cred_or_die 125 115 -10 passwd_main 995 958 -37 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 17/-47) Total: -30 bytes Signed-off-by: Denys Vlasenko

libbb: rename bb_ask -> bb_ask_noecho, bb_ask_confirmation -> bb_ask_y_confirmation

2018-04-07T13:08:12+00:00

Signed-off-by: Denys Vlasenko

config: trim/improve item names and help texts, take 2

2017-07-27T08:53:09+00:00

Signed-off-by: Denys Vlasenko

config: deindent all help texts

2017-07-21T07:50:55+00:00

Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko