busybox-w32/loginutils, branch 1_00

egor duda writes:

2004-10-08T07:46:08+00:00

Hi! I've created a patch to busybox' build system to allow building it in separate tree in a manner similar to kbuild from kernel version 2.6. That is, one runs command like 'make O=/build/some/where/for/specific/target/and/options' and everything is built in this exact directory, provided that it exists. I understand that applyingc such invasive changes during 'release candidates' stage of development is at best unwise. So, i'm currently asking for comments about this patch, starting from whether such thing is needed at all to whether it coded properly. 'make check' should work now, and one make creates Makefile in build directory, so one can run 'make' in build directory after that. One possible caveat is that if we build in some directory other than source one, the source directory should be 'distclean'ed first. egor

Only write to shadow file is shadow passwords are enabled. Patch by magicfox modified by myself to retain check for shadow file access.

2004-09-15T02:39:09+00:00

Patch from tito to add argument checking.

2004-09-14T16:08:02+00:00

Tito writes:

2004-09-02T22:22:17+00:00

The second patch contains: 1) a size optimization for adduser.c 2) removes a warning about an unused variable in syslogd.c if CONFIG_FEATURE_REMOTE_LOG is not set 3)cosmetic fixes for addgroup_full_usage and adduser_full_usage Ciao, Tito

Tito writes:

2004-09-02T22:21:41+00:00

Hi Erik, Hi to all, This is part five of the my_get*id story. I've tweaked a bit this two functions to make them more flexible, but this changes will not affect existing code. Now they work so: 1) my_getpwuid( char *user, uid_t uid, int bufsize) if bufsize is > 0 char *user cannot be set to NULL on success username is written on static allocated buffer on failure uid as string is written to buffer and NULL is returned if bufsize is = 0 char *user can be set to NULL on success username is returned on failure NULL is returned if bufsize is < 0 char *user can be set to NULL on success username is returned on failure an error message is printed and the program exits 2) 1) my_getgrgid( char *group, uid_t uid, int bufsize) if bufsize is > 0 char *group cannot be set to NULL on success groupname is written on static allocated buffer on failure gid as string is written to buffer and NULL is returned if bufsize is = 0 char *group can be set to NULL on success groupname is returned on failure NULL is returned if bufsize is < 0 char *group can be set to nULL on success groupname is returned on failure an error message is printed and the program exits This changes were needed mainly for my new id applet. It is somewhat bigger then the previous but matches the behaviour of GNU id and is capable to handle usernames of whatever length. BTW: at a first look it seems to me that it will integrate well (with just a few changes) with the pending patch in patches/id_groups_alias.patch. The increase in size is balanced by the removal of my_getpwnamegid.c from libbb as this was used only in previous id applet and by size optimizations made possible in whoami.c and in passwd.c. I know that we are in feature freeze but I think that i've tested it enough (at least I hope so.......).

Improve the setuid situation a bit, and make it more apparent

2004-08-26T23:13:00+00:00

when people really ought to make busybox setuid root. -Erik

Save a line or two

2004-08-26T22:26:26+00:00

Patch from Manousaridis Angelos to cleanup stale file descriptors, it was preventing unmounting an initial filesystem.

2004-08-25T02:02:19+00:00

Bertrand Baudet writes:

2004-08-16T09:07:39+00:00

Looks like the -D and -H options of the adduser applet aren't handle properly in BusyBox. This patch fixes the masks definition for those options according to there position in the optstring. Patch against RC2 but should also apply cleanly against CVS. Bertrand

Umm. Not guilty by reason of insanity.

2004-07-30T17:39:08+00:00

-Erik