busybox-w32/miscutils, branch 1_31_1

dc: Parse error & fix out of bounds read in xc_program_printString

2019-10-21T14:54:40+00:00

function old new delta xc_program_print 712 735 +23 Signed-off-by: Brian Foley Signed-off-by: Denys Vlasenko

dc: Fix segfault when executing strings generated using asciify

2019-10-21T14:54:40+00:00

function old new delta zxc_vm_process 6884 6891 +7 Signed-off-by: Brian Foley Signed-off-by: Denys Vlasenko

dc: execute shouldn't pop if stack head is not a string

2019-10-21T14:54:40+00:00

This matches the behaviour of both GNU dc (as specified in its man page), and BSD dc (where stack_popstring() pops only if the head is a string.) Add a couple of tests to verify this behavior. function old new delta zxc_vm_process 6882 6884 +2 Signed-off-by: Brian Foley Signed-off-by: Denys Vlasenko

bc: placate compiler warnings

2019-06-08T10:39:30+00:00

Signed-off-by: Denys Vlasenko

dc: make 4 % 0 emit error messgaes and set result to 0

2019-05-16T07:40:36+00:00

function old new delta mod 105 136 +31 Signed-off-by: Denys Vlasenko

dc: code shrink

2019-05-09T13:58:46+00:00

function old new delta check_under 20 21 +1 print_no_pop 32 27 -5 pop 24 18 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 1/-11) Total: -10 bytes Signed-off-by: Denys Vlasenko

Optionally re-introduce bb_info_msg()

2019-04-30T08:51:27+00:00

Between Busybox 1.24.2 and 1.25.0 the bb_info_msg() function was eliminated and calls to it changed to be bb_error_msg(). The downside of this is that daemons now log all messages to syslog at the LOG_ERR level which makes it hard to filter errors from informational messages. This change optionally re-introduces bb_info_msg(), controlled by a new option FEATURE_SYSLOG_INFO, restores all the calls to bb_info_msg() that were removed (only in applets that set logmode to LOGMODE_SYSLOG or LOGMODE_BOTH), and also changes informational messages in ifplugd and ntpd. The code size change of this is as follows (using 'defconfig' on x86_64 with gcc 7.3.0-27ubuntu1~18.04) function old new delta bb_info_msg - 182 +182 bb_vinfo_msg - 27 +27 static.log7 194 198 +4 log8 190 191 +1 log5 190 191 +1 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 3/0 up/down: 215/-45) Total: 170 bytes If you don't care about everything being logged at LOG_ERR level then when FEATURE_SYSLOG_INFO is disabled Busybox actually gets smaller: function old new delta static.log7 194 200 +6 log8 190 193 +3 log5 190 193 +3 syslog_level 1 - -1 bb_verror_msg 583 581 -2 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 3/1 up/down: 12/-48) Total: -36 bytes Signed-off-by: James Byrne Signed-off-by: Denys Vlasenko

man: add "/usr/share/man" as another default MANPATH, fix col override

2019-03-30T16:27:09+00:00

function old new delta static.mpl - 12 +12 packed_usage 33307 33316 +9 man_main 857 851 -6 add_MANPATH 148 138 -10 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/2 up/down: 21/-16) Total: 5 bytes Signed-off-by: Denys Vlasenko

man: don't skip default path which appears in config file

2019-03-26T16:46:21+00:00

If the MANPATH environment variable isn't set a provisional default path of /usr/man is placed in man_path_list. This is only used if a configuration file doesn't contain an alternative path. If a configuration file lists the default path first: MANPATH /usr/man:/usr/share/man add_MANPATH() sees that the default entry is already present and skips it. As a result man_path_list only contains the second and subsequent components of the configured MANPATH. In such cases the path should not be skipped. function old new delta add_MANPATH 170 183 +13 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/0 up/down: 13/0) Total: 13 bytes Signed-off-by: Ron Yorston Signed-off-by: Denys Vlasenko

ts: do call localtime() when neither -s nor -i specified

2019-03-26T10:51:21+00:00

Signed-off-by: Denys Vlasenko