busybox-w32/scripts/basic/fixdep.c, branch cron_changes

Merge branch 'busybox' into merge

2024-09-28T07:13:32+00:00

fixdep: add fstat error handling

2024-09-27T18:03:30+00:00

When `fstat` fails, `st` is left uninitialised. In our case, Ben Kohler noticed our release media builds were failing in Gentoo on x86 when building busybox with occasional SIGBUS. This turned out to be EOVERFLOW (from 32-bit ino_t) which wasn't being reported because nothing was checking the return value from `fstat`. Fix that to avoid UB (use of uninit var) and to give a more friendly error to the user. This actually turns out to be fixed already in the kernel from back in 2010 [0] and 2016 [1]. [0] https://github.com/torvalds/linux/commit/a3ba81131aca243bfecfa78c42edec0cd69f72d6 [1] https://github.com/torvalds/linux/commit/46fe94ad18aa7ce6b3dad8c035fb538942020f2b Reported-by: Ben Kohler Signed-off-by: Sam James Signed-off-by: Denys Vlasenko

Merge branch 'busybox' into merge

2023-04-09T10:24:09+00:00

fixdep: avoid underflow when end of entry doesn't coincide with EOF

2023-02-27T12:09:44+00:00

Bug: https://bugs.gentoo.org/893776 Closes: https://bugs.busybox.net/show_bug.cgi?id=15326 Signed-off-by: Arsen Arsenović Signed-off-by: Denys Vlasenko

Merge branch 'busybox' into merge

2021-05-14T07:17:12+00:00

fix "warning array subscript has type 'char'"

2021-04-14T17:12:43+00:00

Signed-off-by: Denys Vlasenko

fixdep: fix assumption that `long` is as large as `void *`

2017-07-14T12:47:31+00:00

It is not. At least not in general. And in particular not on 64-bit Windows, where sizeof(long) == 4. What the code wanted to use is actually called intptr_t. Note: `intptr_t` is a C99 feature. Signed-off-by: Johannes Schindelin

fixdep: be careful about handling empty lines correctly

2017-07-14T12:47:31+00:00

The current code without this patch is seriously flawed, as it can easily overrun the buffer while looking for the *beginning* of the line. The symptom when trying to build without this patch in Git for Windows' SDK (which is a special-purpose version of MSYS2) is: $ make mingw64_defconfig && make -j15 HOSTCC scripts/basic/fixdep make[1]: *** [scripts/Makefile.host:104: scripts/basic/fixdep] Error 127 make: *** [Makefile:358: scripts_basic] Error 2 make: *** [Makefile:358: scripts_basic] Error 2 Signed-off-by: Johannes Schindelin

fixdep: read the dependency files in binary mode

2017-07-14T12:47:26+00:00

We want to make sure that the original line endings are preserved, as fixdep hardcodes the assumption of Unix-type line endings. The symptom is this (kinda hard to understand) error when building in Git for Windows' SDK (which is a special-purpose version of MSYS2): $ make mingw64_defconfig && make -j15 HOSTCC scripts/basic/fixdep C:/git-sdk-64/mingw64/x86_64-w64-mingw32/include/ctype.h 64-w64-mingw32/include/ctype.h: Invalid argument fixdep: make[1]: *** [scripts/Makefile.host:104: scripts/basic/fixdep] Error 2 make: *** [Makefile:358: scripts_basic] Error 2 Signed-off-by: Johannes Schindelin

Merge branch 'busybox' into merge

2014-01-13T09:11:24+00:00

Conflicts: include/platform.h scripts/basic/fixdep.c