busybox-w32/shell/ash_test/ash-misc/exitcode_trap7.tests, branch long_pathsA mirror of https://github.com/rmyorston/busybox-w32.git
https://git.lua4.win/busybox-w32/atom?h=long_paths2021-09-07T00:25:52+00:00hush: fix set -n to act immediately, not just after run_list()2021-09-07T00:25:52+00:00Denys Vlasenkovda.linux@googlemail.com2021-09-07T00:23:51+00:00urn:sha1:e53c7dbafc78948e5c0d8d8ccb0bdcd9f936c62e
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
ash: eval: Do not cache value of eflag in evaltree2021-09-07T00:01:03+00:00Denys Vlasenkovda.linux@googlemail.com2021-09-06T23:54:23+00:00urn:sha1:f415e21a7dce1d4f4b760fddfaba85c551681e11
Upsteam commit:
Date: Mon, 17 May 2021 15:19:23 +0800
eval: Do not cache value of eflag in evaltree
Patrick Brünn <P.Bruenn@beckhoff.com> wrote:
> Since we are migrating to Debian bullseye, we discovered a new behavior
> with our scripts, which look like this:
>>cleanup() {
>> set +e
>> rmdir ""
>>}
>>set -eu
>>trap 'cleanup' EXIT INT TERM
>>echo 'Hello world!'
>
> With old dash v0.5.10.2 this script would return 0 as we expected it.
> But since commit 62cf6955f8abe875752d7163f6f3adbc7e49ebae it returns
> the last exit code of our cleanup function.
...
Thanks for the report. This is actually a fairly old bug with
set -e that's just been exposed by the exit status change. What's
really happening is that cleanup itself is triggering a set -e
exit incorrectly because evaltree cached the value of eflag prior
to the function call.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>