A mirror of https://github.com/rmyorston/busybox-w32.git https://git.lua4.win/busybox-w32/atom?h=path_search 2024-06-12T11:43:39+00:00 2024-06-12T11:43:39+00:00 Ron Yorston rmy@pobox.com 2024-06-12T11:34:08+00:00 urn:sha1:2817c3d4f3fb60b6719782cde57a6b7347cf2898 In recent versions of Windows the PATH environment variable has a trailing semicolon. This is insignificant to Windows because it's ignored. busybox-w32 conforms to the POSIX interpretation of PATH which treats an empty path element as denoting the current directory. As result, on these versions of Windows executables may by default be run from the current directory, contrary to usual Unix practice. Attempt to detect and remove the trailing semicolon on applet start up. If the user insists, they can add a trailing semicolon to the shell variable PATH and it will be respected in the conventional manner. Adds 88-112 bytes. 2024-05-22T06:51:34+00:00 Ron Yorston rmy@pobox.com 2024-05-22T06:51:34+00:00 urn:sha1:a643b5541b71ce5413739a93a560e097947afece 2024-05-21T07:36:09+00:00 Ron Yorston rmy@pobox.com 2024-05-21T07:36:09+00:00 urn:sha1:05b053cd388219d6b194b99ce9e543271dab121f The Cygwin terminal program mintty sets the HOME environment variable. Attempt to detect this and unset HOME so the usual busybox-w32 initialisation of HOME is used instead. Adds 80 bytes. (GitHub issue #420) 2024-05-10T13:32:45+00:00 Ron Yorston rmy@pobox.com 2024-05-10T13:32:45+00:00 urn:sha1:bb128070e590234f8b63fb1d67f7621a1b4b3ff3 When a shell was started with the -X option, environment variables had forward slashes changed to backslashes. This is unnecessary and counterproductive. Adjust how the state of winxp is handled to avoid this. (GitHub issue #415) 2024-04-30T09:15:24+00:00 Ron Yorston rmy@pobox.com 2024-04-30T09:15:24+00:00 urn:sha1:8e0a1ad5e4c1fa3698cc581fedcaf339a3387a35 2024-04-30T08:08:00+00:00 Ron Yorston rmy@pobox.com 2024-04-30T08:08:00+00:00 urn:sha1:6b164f335c548bcebacd8bf984fd5c34ede46891 An alias expansion immediately followed by '&' is parsed incorrectly: ~ $ alias x='sleep 2' ~ $ x& ~ $ sh: syntax error: unexpected "&" The sleep happens in the foreground and the '&' is left in the input buffer. The same problem occurs in upstream BusyBox but not dash. The difference between BusyBox and dash is that BusyBox supports bash-style output redirection (BASH_REDIR_OUTPUT in the code). This requires checking for '&>' in readtoken1(). When the end of the alias is found, the '&' and the following newline are both read to check for '&>'. Since there's no match both characters are pushed back. The alias is then expanded and __pgetc() is called to fetch the next character. Since there are none left in the alias string __pgetc() calls preadbuffer() which pops the string, reverts to the previous input and recursively calls __pgetc(). This request is satisified from the pungetc buffer. But the first __pgetc() doesn't know this: it sees the character has come from preadbuffer() so it (incorrectly) updates the pungetc buffer. Resolve the issue by moving the code to pop the string and fetch the next character up from preadbuffer() into __pgetc(). Saves 32-48 bytes. (GitHub issue #413) 2024-04-29T10:10:53+00:00 Ron Yorston rmy@pobox.com 2024-04-29T10:10:53+00:00 urn:sha1:818cf3b0c7dae0b06d0103998f1eef14964b63c7 The 'noiconify' option controls how the console window is concealed when the 'noconsole' option is used. The default is to iconify the console. When 'noiconify' is 'on' the console is hidden. Adds 8-16 bytes. (GitHub issue #325) 2024-04-29T09:37:59+00:00 Ron Yorston rmy@pobox.com 2024-04-29T09:37:59+00:00 urn:sha1:af195b0c979c53739d0ba7e054667b3c548feaa9 Commit 67ed7484be (ash: detect console state on shell start up) synchronised the noconsole option with the actual state of the window on shell start up. This is insufficient. The user can change the state of the window independently of the noconsole option, leading to confusion and unwanted iconification of the window when unrelated 'set' commands are issued. Detect the current console state on every call to options(). Saves 16-32 bytes. (GitHub issue #325) 2024-04-22T06:54:34+00:00 Ron Yorston rmy@pobox.com 2024-04-22T06:54:34+00:00 urn:sha1:b5131ae1c0bb7984b35c909d04e2f4a61a7b6d8f Mixing Windows and Unix-style filename extensions was causing problems. Tweak how extensions are handled to try and improve matters: - Consistently check whether the unaltered filename is an executable before trying adding extensions. - Check .exe and .com before .sh. Saves up to 16 bytes. (GitHub issue #405) 2024-04-09T11:43:48+00:00 Ron Yorston rmy@pobox.com 2024-04-09T11:43:48+00:00 urn:sha1:7e09f7ce4e0d99b0e54684e5cc506e1532db392f The undocumented '-d' shell option is used to set the current directory in shells started by the 'su' applet of busybox-w32. In this case, the shell isn't a login shell. If a login shell sets the current working directory in /etc/profile it's possible the user may wish to override this with '-d'. This didn't work, though, because the directory is changed before /etc/profile is processed. Move the changing of the directory to that specified by '-d' so it happens after the processing of /etc/profile and ~/.profile. This won't affect the intended use of '-d'. (GitHub issue #403)