busybox-w32/shell, branch tab_completion

hush: code shrink

2023-04-13T07:47:36+00:00

Handle both arrays of builtin as the same type. function old new delta ash_command_name - 154 +154 hush_command_name - 97 +97 complete_cmd_dir_file 876 880 +4 ash_builtin_name 17 - -17 hush_builtin_name 38 - -38 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/0 up/down: 255/-55) Total: 200 bytes In the case where ash is disabled and hush is enabled but with support for functions disabled this reduces the bloat from 31 to 6 bytes. (GitHub issue #301) Signed-off-by: Ron Yorston

ash: fix tab completion

2023-04-11T12:27:24+00:00

The initial index for the command and alias tables was incorrect. Change since 3165054d2: function old new delta ash_command_name - 155 +155 hush_command_name - 110 +110 complete_cmd_dir_file 876 880 +4 ash_builtin_name 17 - -17 hush_builtin_name 38 - -38 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/0 up/down: 269/-55) Total: 214 bytes (GitHub commit #301) Signed-off-by: Ron Yorston

ash,hush: improvements to tab completion

2023-04-11T12:03:15+00:00

Cosmetic changes. Avoid accessing beyond the end of the command and alias arrays in ash. Code shrink. Change since commit 3165054d2: function old new delta ash_command_name - 153 +153 hush_command_name - 110 +110 complete_cmd_dir_file 876 880 +4 ash_builtin_name 17 - -17 hush_builtin_name 38 - -38 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/0 up/down: 267/-55) Total: 212 bytes (GitHub issue #301) Signed-off-by: Ron Yorston

ash,hush: tab completion of functions and aliases

2023-04-10T10:45:46+00:00

Rework the 'get_exe_name' functions in ash and hush so functions and aliases are considered when tab-completing a command. function old new delta ash_command_name - 188 +188 hush_command_name - 118 +118 complete_cmd_dir_file 876 880 +4 ash_builtin_name 17 - -17 hush_builtin_name 38 - -38 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/0 up/down: 310/-55) Total: 255 bytes (GitHub issue #301) Signed-off-by: Ron Yorston

ash,hush: rename get_builtin_name

2023-04-10T10:45:42+00:00

Rename get_builtin_name() in ash and hush to avoid confusing bloatcheck. No functional changes. (GitHub issue #301) Signed-off-by: Ron Yorston

ash: code shrink: do not take address of prefix(), allowing it to inline

2023-04-03T15:30:03+00:00

function old new delta getjob 281 285 +4 prefix 13 - -13 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/0 up/down: 4/-13) Total: -9 bytes Signed-off-by: Denys Vlasenko

ash: code shrink - reuse is_prefixed_with() from libbb

2023-04-03T13:19:13+00:00

function old new delta changepath 67 68 +1 legal_pathopt 70 66 -4 prefix 34 13 -21 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 1/-25) Total: -24 bytes Signed-off-by: Denys Vlasenko

ash: get rid of separate mail_var_path_changed flag variable

2023-04-03T13:01:00+00:00

We can just clear mailtime_hash to zero and have the same effect. function old new delta changemail 8 11 +3 mail_var_path_changed 1 - -1 cmdloop 398 382 -16 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/1 up/down: 3/-17) Total: -14 bytes text data bss dec hex filename 1054786 559 5020 1060365 102e0d busybox_old 1054773 559 5020 1060352 102e00 busybox_unstripped Signed-off-by: Denys Vlasenko

ash: fix still-broken new mail detection

2023-04-03T12:41:01+00:00

padvance() exit condition is return value < 0, not == 0. After MAIL changing twice, the logic erroneously concluded that "you have new mail". Signed-off-by: Denys Vlasenko

ash: fix broken new mail detection

2023-04-03T12:01:36+00:00

Mea culpa, in "Do not allocate stack string in padvance" commit (I left an extraneous "break" statement). function old new delta cmdloop 329 398 +69 Signed-off-by: Denys Vlasenko