summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Vlasenko <vda.linux@googlemail.com>2008-04-11 10:54:37 +0000
committerDenis Vlasenko <vda.linux@googlemail.com>2008-04-11 10:54:37 +0000
commit80f647c21c4457b5f74f5cdd87b789a0fa0d7c0d (patch)
treeca05202bb6c034cc8a6969d21abfa3ff39fb86de
parent119f87be2a4fb8d45a67be19f0341b8f3d96b091 (diff)
downloadbusybox-w32-80f647c21c4457b5f74f5cdd87b789a0fa0d7c0d.tar.gz
busybox-w32-80f647c21c4457b5f74f5cdd87b789a0fa0d7c0d.tar.bz2
busybox-w32-80f647c21c4457b5f74f5cdd87b789a0fa0d7c0d.zip
build system: use POSIX options only for cp
cp: improve comment
-rw-r--r--Makefile.custom5
-rw-r--r--coreutils/cp.c2
2 files changed, 4 insertions, 3 deletions
diff --git a/Makefile.custom b/Makefile.custom
index e4a616f65..3334b31eb 100644
--- a/Makefile.custom
+++ b/Makefile.custom
@@ -47,10 +47,11 @@ ifneq ($(strip $(DO_INSTALL_LIBS)),n)
47endif 47endif
48 48
49# Not very elegant: copies testsuite to objdir... 49# Not very elegant: copies testsuite to objdir...
50# (cp -pPR is POSIX-compliant (cp -dpR or cp -a would not be))
50.PHONY: check 51.PHONY: check
51.PHONY: test 52.PHONY: test
52check test: busybox busybox.links 53check test: busybox busybox.links
53 test -d $(objtree)/testsuite || cp -a $(srctree)/testsuite $(objtree) 54 test -d $(objtree)/testsuite || cp -pPR $(srctree)/testsuite $(objtree)
54 bindir=$(objtree) srcdir=$(srctree)/testsuite \ 55 bindir=$(objtree) srcdir=$(srctree)/testsuite \
55 $(SHELL) -c "cd $(objtree)/testsuite && $(srctree)/testsuite/runtest $(if $(KBUILD_VERBOSE:0=),-v)" 56 $(SHELL) -c "cd $(objtree)/testsuite && $(srctree)/testsuite/runtest $(if $(KBUILD_VERBOSE:0=),-v)"
56 57
@@ -58,7 +59,7 @@ check test: busybox busybox.links
58release: distclean 59release: distclean
59 cd ..; \ 60 cd ..; \
60 rm -r -f busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION); \ 61 rm -r -f busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION); \
61 cp -a busybox busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) && { \ 62 cp -pPR busybox busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) && { \
62 find busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ -type d \ 63 find busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ -type d \
63 -name .svn \ 64 -name .svn \
64 -print \ 65 -print \
diff --git a/coreutils/cp.c b/coreutils/cp.c
index 6cf1e21a1..a4eea9498 100644
--- a/coreutils/cp.c
+++ b/coreutils/cp.c
@@ -44,7 +44,7 @@ int cp_main(int argc, char **argv)
44 // Soft- and hardlinking don't mix 44 // Soft- and hardlinking don't mix
45 // -P and -d are the same (-P is POSIX, -d is GNU) 45 // -P and -d are the same (-P is POSIX, -d is GNU)
46 // -r and -R are the same 46 // -r and -R are the same
47 // -R (and therefore -r) switches on -d (coreutils does this) 47 // -R (and therefore -r) turns on -d (coreutils does this)
48 // -a = -pdR 48 // -a = -pdR
49 opt_complementary = "-2:l--s:s--l:Pd:rRd:Rd:apdR"; 49 opt_complementary = "-2:l--s:s--l:Pd:rRd:Rd:apdR";
50 flags = getopt32(argv, FILEUTILS_CP_OPTSTR "arPHL"); 50 flags = getopt32(argv, FILEUTILS_CP_OPTSTR "arPHL");