ash: fix waiting for status of background job

The following has never worked properly in busybox-w32:

   $ my_func() { return 5; }
   $ my_func & sleep 1; wait $!; echo $?

The expected result is that 'echo' should display '5'.  Actual
results used to be '0' and more recently have been '127'.

The culprit was commit fa6f44ea72 (win32: ash: reimplement
waitpid(-1)).  When the status of a job changed its pid was set to
-1, which flagged processes of interest to the implementation of
waitpid().

This is no longer necessary as waitpid() now uses the process
handle instead.  There's therefore no need to overwrite the pid.

(GitHub issue #470)

1 files changed, 0 insertions, 1 deletions

diff --git a/shell/ash.c b/shell/ash.c
index f21ef85d4..fd2a66270 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -5070,7 +5070,6 @@ waitone(int block, struct job *job)
                                 ps->ps_status = status;
                                 thisjob = jp;
 #if ENABLE_PLATFORM_MINGW32
-                                ps->ps_pid = -1;
                                 CloseHandle(ps->ps_proc);
                                 ps->ps_proc = NULL;
 #endif