diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2011-04-16 19:31:08 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2011-04-16 19:31:08 +0200 |
commit | d506897b4ef94a85013696d543686162293a02f1 (patch) | |
tree | eea4485c972188a7740f668a929a4e3cb5c3f3f7 | |
parent | 43a3d50e14902e746ee53b7cfb63fe190bd5387f (diff) | |
download | busybox-w32-d506897b4ef94a85013696d543686162293a02f1.tar.gz busybox-w32-d506897b4ef94a85013696d543686162293a02f1.tar.bz2 busybox-w32-d506897b4ef94a85013696d543686162293a02f1.zip |
wget: add a note about bug 3625
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r-- | networking/wget.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/networking/wget.c b/networking/wget.c index 3a4be9878..df6d36358 100644 --- a/networking/wget.c +++ b/networking/wget.c | |||
@@ -661,6 +661,12 @@ static void download_one_url(const char *url) | |||
661 | 661 | ||
662 | #if ENABLE_FEATURE_WGET_AUTHENTICATION | 662 | #if ENABLE_FEATURE_WGET_AUTHENTICATION |
663 | if (target.user) { | 663 | if (target.user) { |
664 | //TODO: URL-decode "user:password" string before base64-encoding: | ||
665 | //wget http://test:my%20pass@example.com should send | ||
666 | // Authorization: Basic dGVzdDpteSBwYXNz | ||
667 | //which decodes to "test:my pass", instead of what we send now: | ||
668 | // Authorization: Basic dGVzdDpteSUyMHBhc3M= | ||
669 | //Can reuse decodeString() from httpd.c | ||
664 | fprintf(sfp, "Proxy-Authorization: Basic %s\r\n"+6, | 670 | fprintf(sfp, "Proxy-Authorization: Basic %s\r\n"+6, |
665 | base64enc(target.user)); | 671 | base64enc(target.user)); |
666 | } | 672 | } |