diff options
| author | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2006-06-04 16:05:02 +0000 |
|---|---|---|
| committer | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2006-06-04 16:05:02 +0000 |
| commit | 863073da0858b07149d4c15d13d1ac0b1a769eb0 (patch) | |
| tree | 8f3d93ba1eaf148433dcba0078fcc344ddcb2f00 /TODO | |
| parent | 395010b1f05911ddcba304bc591ec58950f118c9 (diff) | |
| download | busybox-w32-863073da0858b07149d4c15d13d1ac0b1a769eb0.tar.gz busybox-w32-863073da0858b07149d4c15d13d1ac0b1a769eb0.tar.bz2 busybox-w32-863073da0858b07149d4c15d13d1ac0b1a769eb0.zip | |
- add note about removing superfluous fmt specifiers
Diffstat (limited to 'TODO')
| -rw-r--r-- | TODO | 9 |
1 files changed, 7 insertions, 2 deletions
| @@ -259,12 +259,17 @@ Minor stuff: | |||
| 259 | if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); | 259 | if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); |
| 260 | Unfortunately, that needs linux/watchdog.h and that contains unfiltered | 260 | Unfortunately, that needs linux/watchdog.h and that contains unfiltered |
| 261 | kernel types on some distros, which breaks the build. | 261 | kernel types on some distros, which breaks the build. |
| 262 | 262 | --- | |
| 263 | use bb_error_msg where appropriate: See | 263 | use bb_error_msg where appropriate: See |
| 264 | egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" | 264 | egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" |
| 265 | 265 | --- | |
| 266 | use bb_perror_msg where appropriate: See | 266 | use bb_perror_msg where appropriate: See |
| 267 | egrep "[^_]perror" | 267 | egrep "[^_]perror" |
| 268 | --- | ||
| 269 | Remove superfluous fmt occurances: e.g. | ||
| 270 | fprintf(stderr, "%s: %s not found\n", "unalias", *argptr); | ||
| 271 | -> fprintf(stderr, "unalias: %s not found\n", *argptr); | ||
| 272 | --- | ||
| 268 | 273 | ||
| 269 | 274 | ||
| 270 | Code cleanup: | 275 | Code cleanup: |