Another nice cleanup from Larry. This adds a new last_char_is() function and

uses it to avoid possible buffer underruns whn strlen is zero, and avoid the
possible space-hogging inline of strlen() in several cases.
 -Erik

1 files changed, 1 insertions, 1 deletions

diff --git a/archival/tar.c b/archival/tar.c
index 48284c00a..716f4ac30 100644
--- a/archival/tar.c
+++ b/archival/tar.c
@@ -706,7 +706,7 @@ static int readTarFile(int tarFd, int extractFlag, int listFlag,
                         case REGTYPE0:
                                 /* If the name ends in a '/' then assume it is
                                  * supposed to be a directory, and fall through */
-                                if (header.name[strlen(header.name)-1] != '/') {
+                                if (last_char_is(header.name,'/')) {
                                         if (tarExtractRegularFile(&header, extractFlag, tostdoutFlag)==FALSE)
                                                 errorFlag=TRUE;
                                         break;