diff options
author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-01-02 19:55:04 +0000 |
---|---|---|
committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-01-02 19:55:04 +0000 |
commit | fb0eba706cccd510d99c4c5339a76dd15bc8a628 (patch) | |
tree | 45122b93a1a5d628e4aa146251e34397094de817 /archival | |
parent | 27963980dbe1262fd6c447fc7d06839aea0861bc (diff) | |
download | busybox-w32-fb0eba706cccd510d99c4c5339a76dd15bc8a628.tar.gz busybox-w32-fb0eba706cccd510d99c4c5339a76dd15bc8a628.tar.bz2 busybox-w32-fb0eba706cccd510d99c4c5339a76dd15bc8a628.zip |
libbb: introduce and use safe_waitpid (loops in EINTR)
*: use more approproate (shorter) versions of wait()
function old new delta
safe_waitpid - 48 +48
wait_any_nohang - 17 +17
send_tree 365 369 +4
processorstop 432 435 +3
text_yank 110 108 -2
make_human_readable_str 202 200 -2
crond_main 1368 1366 -2
handle_sigchld 49 43 -6
reapchild 166 159 -7
custom 260 250 -10
checkscript 191 177 -14
wait_nohang 17 - -17
wait_pid 43 - -43
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 2/7 up/down: 72/-103) Total: -31 bytes
Diffstat (limited to 'archival')
-rw-r--r-- | archival/tar.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/archival/tar.c b/archival/tar.c index 5b19093e8..64975c428 100644 --- a/archival/tar.c +++ b/archival/tar.c | |||
@@ -610,7 +610,7 @@ static int writeTarFile(const int tar_fd, const int verboseFlag, | |||
610 | 610 | ||
611 | if (gzipPid) { | 611 | if (gzipPid) { |
612 | int status; | 612 | int status; |
613 | if (waitpid(gzipPid, &status, 0) == -1) | 613 | if (safe_waitpid(gzipPid, &status, 0) == -1) |
614 | bb_perror_msg("waitpid"); | 614 | bb_perror_msg("waitpid"); |
615 | else if (!WIFEXITED(status) || WEXITSTATUS(status)) | 615 | else if (!WIFEXITED(status) || WEXITSTATUS(status)) |
616 | /* gzip was killed or has exited with nonzero! */ | 616 | /* gzip was killed or has exited with nonzero! */ |
@@ -688,7 +688,7 @@ static void handle_SIGCHLD(int status) | |||
688 | /* Actually, 'status' is a signo. We reuse it for other needs */ | 688 | /* Actually, 'status' is a signo. We reuse it for other needs */ |
689 | 689 | ||
690 | /* Wait for any child without blocking */ | 690 | /* Wait for any child without blocking */ |
691 | if (waitpid(-1, &status, WNOHANG) < 0) | 691 | if (wait_any_nohang(&status) < 0) |
692 | /* wait failed?! I'm confused... */ | 692 | /* wait failed?! I'm confused... */ |
693 | return; | 693 | return; |
694 | 694 | ||