unpackers: check errors from close() too

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/archival/bbunzip.c b/archival/bbunzip.c
index d25f50939..d6625e476 100644
--- a/archival/bbunzip.c
+++ b/archival/bbunzip.c
@@ -98,6 +98,7 @@ int FAST_FUNC bbunpack(char **argv,
                 status = unpacker(&info);
                 if (status < 0)
                         exitcode = 1;
+                xclose(STDOUT_FILENO); /* with error check! */
 
                 if (filename) {
                         char *del = new_name;
@@ -108,12 +109,11 @@ int FAST_FUNC bbunpack(char **argv,
 
                                         times.actime = info.mtime;
                                         times.modtime = info.mtime;
-                                        /* Close first.
+                                        /* Note: we closed it first.
                                          * On some systems calling utime
-                                         * then closing resets the mtime. */
-                                        close(STDOUT_FILENO);
-                                        /* Ignoring errors */
-                                        utime(new_name, &times);
+                                         * then closing resets the mtime
+                                         * back to current time. */
+                                        utime(new_name, &times); /* ignoring errors */
                                 }
 
                                 /* Delete _compressed_ file */