diff options
author | Denis Vlasenko <vda.linux@googlemail.com> | 2007-06-04 10:16:52 +0000 |
---|---|---|
committer | Denis Vlasenko <vda.linux@googlemail.com> | 2007-06-04 10:16:52 +0000 |
commit | 74324c86663f57a19c1de303ee8c8e5449db9ef2 (patch) | |
tree | 11f5da9de4212875ce5811be2e1050e076378c9a /coreutils/catv.c | |
parent | 4e5f82c76f08614d0b69f9ec4a8baac303af15f6 (diff) | |
download | busybox-w32-74324c86663f57a19c1de303ee8c8e5449db9ef2.tar.gz busybox-w32-74324c86663f57a19c1de303ee8c8e5449db9ef2.tar.bz2 busybox-w32-74324c86663f57a19c1de303ee8c8e5449db9ef2.zip |
Audit bb_common_bufsiz usage, add script which looks for misuse.
tr: stop using globals needlessly.
code: -103 bytes
Diffstat (limited to 'coreutils/catv.c')
-rw-r--r-- | coreutils/catv.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/coreutils/catv.c b/coreutils/catv.c index 2d2229f7f..cc61233e1 100644 --- a/coreutils/catv.c +++ b/coreutils/catv.c | |||
@@ -33,13 +33,14 @@ int catv_main(int argc, char **argv) | |||
33 | else for (;;) { | 33 | else for (;;) { |
34 | int i, res; | 34 | int i, res; |
35 | 35 | ||
36 | res = read(fd, bb_common_bufsiz1, sizeof(bb_common_bufsiz1)); | 36 | #define read_buf bb_common_bufsiz1 |
37 | res = read(fd, read_buf, COMMON_BUFSIZE); | ||
37 | if (res < 0) | 38 | if (res < 0) |
38 | retval = EXIT_FAILURE; | 39 | retval = EXIT_FAILURE; |
39 | if (res < 1) | 40 | if (res < 1) |
40 | break; | 41 | break; |
41 | for (i = 0; i < res; i++) { | 42 | for (i = 0; i < res; i++) { |
42 | char c = bb_common_bufsiz1[i]; | 43 | char c = read_buf[i]; |
43 | 44 | ||
44 | if (c > 126 && (flags & CATV_OPT_v)) { | 45 | if (c > 126 && (flags & CATV_OPT_v)) { |
45 | if (c == 127) { | 46 | if (c == 127) { |