Audit bb_common_bufsiz usage, add script which looks for misuse.

tr: stop using globals needlessly.
code: -103 bytes

1 files changed, 3 insertions, 2 deletions

diff --git a/coreutils/cksum.c b/coreutils/cksum.c
index 865bea0ee..987f5f32c 100644
--- a/coreutils/cksum.c
+++ b/coreutils/cksum.c
@@ -27,8 +27,9 @@ int cksum_main(int argc, char **argv)
                 crc = 0;
                 length = 0;
 
-                while ((bytes_read = fread(bb_common_bufsiz1, 1, BUFSIZ, fp)) > 0) {
-                        cp = bb_common_bufsiz1;
+#define read_buf bb_common_bufsiz1
+                while ((bytes_read = fread(read_buf, 1, BUFSIZ, fp)) > 0) {
+                        cp = read_buf;
                         length += bytes_read;
                         while (bytes_read--)
                                 crc = (crc << 8) ^ crc32_table[((crc >> 24) ^ (*cp++)) & 0xffL];