Steve Grubb writes:

Hi,

I just re-reviewed the patch I just sent...and it needed to be BUFSIZ-3 in
dos2unix.c . tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. The loop
increments by 2. That's why it should be BUFSIZ-3.

Best Regards,
Steve Grubb

1 files changed, 3 insertions, 1 deletions

diff --git a/coreutils/dos2unix.c b/coreutils/dos2unix.c
index c8cebcec7..df0b4f977 100644
--- a/coreutils/dos2unix.c
+++ b/coreutils/dos2unix.c
@@ -64,7 +64,9 @@ static int convert(char *fn, int ConvType)
                 c = strlen(tempFn);
                 tempFn[c] = '.';
                 while(1) {
-                    if (c >=BUFSIZ-2)
+                    /* tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1.
+                     * The loop increments by 2. So this must check for BUFSIZ-3. */
+                    if (c >=BUFSIZ-3)
                         bb_error_msg_and_die("unique name not found");
                     /* Get some semi random stuff to try and make a
                      * random filename based (and in the same dir as)