diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2010-01-04 14:15:38 +0100 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2010-01-04 14:15:38 +0100 |
commit | 2ec91aead52d6ea6a42420005119ebb281a76cdc (patch) | |
tree | 115804c56ff172f96c0138bcabcc7d5e56e5dae0 /coreutils | |
parent | a355da07756e529c112249653ed5af0e2d910728 (diff) | |
download | busybox-w32-2ec91aead52d6ea6a42420005119ebb281a76cdc.tar.gz busybox-w32-2ec91aead52d6ea6a42420005119ebb281a76cdc.tar.bz2 busybox-w32-2ec91aead52d6ea6a42420005119ebb281a76cdc.zip |
*: remove some uses of argc
function old new delta
whoami_main 34 37 +3
logname_main 60 63 +3
hostid_main 35 38 +3
ttysize_main 136 135 -1
nmeter_main 673 672 -1
logger_main 387 386 -1
uuencode_main 330 328 -2
ifupdown_main 2125 2123 -2
mesg_main 158 155 -3
free_main 333 330 -3
cal_main 902 899 -3
acpid_main 443 440 -3
ar_main 196 189 -7
find_main 476 467 -9
ifconfig_main 1235 1221 -14
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/12 up/down: 9/-49) Total: -40 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'coreutils')
-rw-r--r-- | coreutils/cal.c | 14 | ||||
-rw-r--r-- | coreutils/hostid.c | 4 | ||||
-rw-r--r-- | coreutils/logname.c | 4 | ||||
-rw-r--r-- | coreutils/nohup.c | 4 | ||||
-rw-r--r-- | coreutils/uuencode.c | 4 | ||||
-rw-r--r-- | coreutils/whoami.c | 4 |
6 files changed, 17 insertions, 17 deletions
diff --git a/coreutils/cal.c b/coreutils/cal.c index 7973b82a1..1f498fb7f 100644 --- a/coreutils/cal.c +++ b/coreutils/cal.c | |||
@@ -77,7 +77,7 @@ static char *build_row(char *p, unsigned *dp); | |||
77 | #define HEAD_SEP 2 /* spaces between day headings */ | 77 | #define HEAD_SEP 2 /* spaces between day headings */ |
78 | 78 | ||
79 | int cal_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 79 | int cal_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
80 | int cal_main(int argc, char **argv) | 80 | int cal_main(int argc UNUSED_PARAM, char **argv) |
81 | { | 81 | { |
82 | struct tm *local_time; | 82 | struct tm *local_time; |
83 | struct tm zero_tm; | 83 | struct tm zero_tm; |
@@ -92,13 +92,8 @@ int cal_main(int argc, char **argv) | |||
92 | option_mask32 &= 1; | 92 | option_mask32 &= 1; |
93 | month = 0; | 93 | month = 0; |
94 | argv += optind; | 94 | argv += optind; |
95 | argc -= optind; | ||
96 | 95 | ||
97 | if (argc > 2) { | 96 | if (!argv[0]) { |
98 | bb_show_usage(); | ||
99 | } | ||
100 | |||
101 | if (!argc) { | ||
102 | time(&now); | 97 | time(&now); |
103 | local_time = localtime(&now); | 98 | local_time = localtime(&now); |
104 | year = local_time->tm_year + 1900; | 99 | year = local_time->tm_year + 1900; |
@@ -106,7 +101,10 @@ int cal_main(int argc, char **argv) | |||
106 | month = local_time->tm_mon + 1; | 101 | month = local_time->tm_mon + 1; |
107 | } | 102 | } |
108 | } else { | 103 | } else { |
109 | if (argc == 2) { | 104 | if (argv[1]) { |
105 | if (argv[2]) { | ||
106 | bb_show_usage(); | ||
107 | } | ||
110 | month = xatou_range(*argv++, 1, 12); | 108 | month = xatou_range(*argv++, 1, 12); |
111 | } | 109 | } |
112 | year = xatou_range(*argv, 1, 9999); | 110 | year = xatou_range(*argv, 1, 9999); |
diff --git a/coreutils/hostid.c b/coreutils/hostid.c index 6f007d847..a537e3ad6 100644 --- a/coreutils/hostid.c +++ b/coreutils/hostid.c | |||
@@ -14,9 +14,9 @@ | |||
14 | /* This is a NOFORK applet. Be very careful! */ | 14 | /* This is a NOFORK applet. Be very careful! */ |
15 | 15 | ||
16 | int hostid_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 16 | int hostid_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
17 | int hostid_main(int argc, char **argv UNUSED_PARAM) | 17 | int hostid_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) |
18 | { | 18 | { |
19 | if (argc > 1) { | 19 | if (argv[1]) { |
20 | bb_show_usage(); | 20 | bb_show_usage(); |
21 | } | 21 | } |
22 | 22 | ||
diff --git a/coreutils/logname.c b/coreutils/logname.c index 7e5013255..8357b9a33 100644 --- a/coreutils/logname.c +++ b/coreutils/logname.c | |||
@@ -25,11 +25,11 @@ | |||
25 | /* This is a NOFORK applet. Be very careful! */ | 25 | /* This is a NOFORK applet. Be very careful! */ |
26 | 26 | ||
27 | int logname_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 27 | int logname_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
28 | int logname_main(int argc, char **argv UNUSED_PARAM) | 28 | int logname_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) |
29 | { | 29 | { |
30 | char buf[64]; | 30 | char buf[64]; |
31 | 31 | ||
32 | if (argc > 1) { | 32 | if (argv[1]) { |
33 | bb_show_usage(); | 33 | bb_show_usage(); |
34 | } | 34 | } |
35 | 35 | ||
diff --git a/coreutils/nohup.c b/coreutils/nohup.c index c9e65d2ba..4f6385f8e 100644 --- a/coreutils/nohup.c +++ b/coreutils/nohup.c | |||
@@ -39,7 +39,9 @@ int nohup_main(int argc UNUSED_PARAM, char **argv) | |||
39 | 39 | ||
40 | xfunc_error_retval = 127; | 40 | xfunc_error_retval = 127; |
41 | 41 | ||
42 | if (!argv[1]) bb_show_usage(); | 42 | if (!argv[1]) { |
43 | bb_show_usage(); | ||
44 | } | ||
43 | 45 | ||
44 | /* If stdin is a tty, detach from it. */ | 46 | /* If stdin is a tty, detach from it. */ |
45 | if (isatty(STDIN_FILENO)) { | 47 | if (isatty(STDIN_FILENO)) { |
diff --git a/coreutils/uuencode.c b/coreutils/uuencode.c index e19f99676..bf661851d 100644 --- a/coreutils/uuencode.c +++ b/coreutils/uuencode.c | |||
@@ -16,7 +16,7 @@ enum { | |||
16 | }; | 16 | }; |
17 | 17 | ||
18 | int uuencode_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 18 | int uuencode_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
19 | int uuencode_main(int argc, char **argv) | 19 | int uuencode_main(int argc UNUSED_PARAM, char **argv) |
20 | { | 20 | { |
21 | struct stat stat_buf; | 21 | struct stat stat_buf; |
22 | int src_fd = STDIN_FILENO; | 22 | int src_fd = STDIN_FILENO; |
@@ -32,7 +32,7 @@ int uuencode_main(int argc, char **argv) | |||
32 | tbl = bb_uuenc_tbl_base64; | 32 | tbl = bb_uuenc_tbl_base64; |
33 | } | 33 | } |
34 | argv += optind; | 34 | argv += optind; |
35 | if (argc == optind + 2) { | 35 | if (argv[1]) { |
36 | src_fd = xopen(*argv, O_RDONLY); | 36 | src_fd = xopen(*argv, O_RDONLY); |
37 | fstat(src_fd, &stat_buf); | 37 | fstat(src_fd, &stat_buf); |
38 | mode = stat_buf.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO); | 38 | mode = stat_buf.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO); |
diff --git a/coreutils/whoami.c b/coreutils/whoami.c index 1031cdbf8..22d722ec7 100644 --- a/coreutils/whoami.c +++ b/coreutils/whoami.c | |||
@@ -14,9 +14,9 @@ | |||
14 | /* This is a NOFORK applet. Be very careful! */ | 14 | /* This is a NOFORK applet. Be very careful! */ |
15 | 15 | ||
16 | int whoami_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 16 | int whoami_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
17 | int whoami_main(int argc, char **argv UNUSED_PARAM) | 17 | int whoami_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM) |
18 | { | 18 | { |
19 | if (argc > 1) | 19 | if (argv[1]) |
20 | bb_show_usage(); | 20 | bb_show_usage(); |
21 | 21 | ||
22 | /* Will complain and die if username not found */ | 22 | /* Will complain and die if username not found */ |