diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2020-10-01 21:52:16 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2020-10-01 21:52:16 +0200 |
commit | 689d0650ab63425adaea26afe347015a204958ee (patch) | |
tree | 9c2e10b952cad6804359bc10ccc963ff138fc3d4 /findutils/find.c | |
parent | 3c3928fc658bddacd4e540589868bc28a8e4ca0a (diff) | |
download | busybox-w32-689d0650ab63425adaea26afe347015a204958ee.tar.gz busybox-w32-689d0650ab63425adaea26afe347015a204958ee.tar.bz2 busybox-w32-689d0650ab63425adaea26afe347015a204958ee.zip |
libbb: shrink recursive_action() by reducing memory pressure
function old new delta
recursive_action1 - 316 +316
file_action_grep 161 164 +3
add_to_prg_cache_if_socket 202 205 +3
depmod_main 509 511 +2
writeFileToTarball 488 489 +1
parse_module 281 282 +1
fileAction 207 208 +1
act 189 190 +1
add_to_dirlist 65 64 -1
writeTarFile 196 194 -2
uuidcache_init 47 45 -2
uuidcache_check_device 109 107 -2
true_action 8 6 -2
run_parts_main 310 308 -2
netstat_main 534 532 -2
lsusb_main 29 27 -2
lspci_main 45 43 -2
initial_scan 138 136 -2
grep_main 845 843 -2
find_main 482 480 -2
config_file_action 437 435 -2
chmod_main 142 140 -2
dirAction 14 10 -4
diff_main 1544 1540 -4
chown_main 154 148 -6
skip_dir 136 129 -7
dir_act 191 184 -7
recursive_action 453 69 -384
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 7/20 up/down: 328/-439) Total: -111 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'findutils/find.c')
-rw-r--r-- | findutils/find.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/findutils/find.c b/findutils/find.c index 9a2c61b75..e2947afb4 100644 --- a/findutils/find.c +++ b/findutils/find.c | |||
@@ -889,10 +889,10 @@ ACTF(links) | |||
889 | } | 889 | } |
890 | #endif | 890 | #endif |
891 | 891 | ||
892 | static int FAST_FUNC fileAction(const char *fileName, | 892 | static int FAST_FUNC fileAction( |
893 | struct stat *statbuf, | 893 | struct recursive_state *state IF_NOT_FEATURE_FIND_MAXDEPTH(UNUSED_PARAM), |
894 | void *userData UNUSED_PARAM, | 894 | const char *fileName, |
895 | int depth IF_NOT_FEATURE_FIND_MAXDEPTH(UNUSED_PARAM)) | 895 | struct stat *statbuf) |
896 | { | 896 | { |
897 | int r; | 897 | int r; |
898 | int same_fs = 1; | 898 | int same_fs = 1; |
@@ -911,12 +911,12 @@ static int FAST_FUNC fileAction(const char *fileName, | |||
911 | #endif | 911 | #endif |
912 | 912 | ||
913 | #if ENABLE_FEATURE_FIND_MAXDEPTH | 913 | #if ENABLE_FEATURE_FIND_MAXDEPTH |
914 | if (depth < G.minmaxdepth[0]) { | 914 | if (state->depth < G.minmaxdepth[0]) { |
915 | if (same_fs) | 915 | if (same_fs) |
916 | return TRUE; /* skip this, continue recursing */ | 916 | return TRUE; /* skip this, continue recursing */ |
917 | return SKIP; /* stop recursing */ | 917 | return SKIP; /* stop recursing */ |
918 | } | 918 | } |
919 | if (depth > G.minmaxdepth[1]) | 919 | if (state->depth > G.minmaxdepth[1]) |
920 | return SKIP; /* stop recursing */ | 920 | return SKIP; /* stop recursing */ |
921 | #endif | 921 | #endif |
922 | 922 | ||
@@ -927,7 +927,7 @@ static int FAST_FUNC fileAction(const char *fileName, | |||
927 | 927 | ||
928 | #if ENABLE_FEATURE_FIND_MAXDEPTH | 928 | #if ENABLE_FEATURE_FIND_MAXDEPTH |
929 | if (S_ISDIR(statbuf->st_mode)) { | 929 | if (S_ISDIR(statbuf->st_mode)) { |
930 | if (depth == G.minmaxdepth[1]) | 930 | if (state->depth == G.minmaxdepth[1]) |
931 | return SKIP; | 931 | return SKIP; |
932 | } | 932 | } |
933 | #endif | 933 | #endif |
@@ -1570,8 +1570,7 @@ int find_main(int argc UNUSED_PARAM, char **argv) | |||
1570 | G.recurse_flags,/* flags */ | 1570 | G.recurse_flags,/* flags */ |
1571 | fileAction, /* file action */ | 1571 | fileAction, /* file action */ |
1572 | fileAction, /* dir action */ | 1572 | fileAction, /* dir action */ |
1573 | NULL, /* user data */ | 1573 | NULL) /* user data */ |
1574 | 0) /* depth */ | ||
1575 | ) { | 1574 | ) { |
1576 | G.exitstatus |= EXIT_FAILURE; | 1575 | G.exitstatus |= EXIT_FAILURE; |
1577 | } | 1576 | } |