win32: always use safe API calls to manipulate environment

It turns out that with the new toolchain safe API calls work on all
all platforms.  Even the original code from commit fa147bd7e works
on Windows XP when built with the new tools.

- Remove the unsafe environment manipulation via the environ array
- Microsoft's putenv takes a copy of its argument so the string
  can be freed
- Rewrite some routines and add more error checking

1 files changed, 0 insertions, 6 deletions

diff --git a/include/mingw.h b/include/mingw.h
index 87abd077b..6f69913d6 100644
--- a/include/mingw.h
+++ b/include/mingw.h
@@ -195,16 +195,10 @@ char *mingw_mktemp(char *template);
 int mkstemp(char *template);
 char *realpath(const char *path, char *resolved_path);
 int setenv(const char *name, const char *value, int replace);
-#if ENABLE_SAFE_ENV
 int unsetenv(const char *env);
-#else
-void unsetenv(const char *env);
-#endif
 
 #define getenv mingw_getenv
-#if ENABLE_SAFE_ENV
 #define putenv mingw_putenv
-#endif
 #define mktemp mingw_mktemp
 
 /*