win32: revert 'don't set error mode'

Commit eb376b5d1 (win32: don't set error mode) removed a call to
SetErrorMode(SEM_FAILCRITICALERRORS).

But the documentation says:

  Best practice is that all applications call the process-wide
  SetErrorMode function with a parameter of SEM_FAILCRITICALERRORS
  at startup. This is to prevent error mode dialogs from hanging
  the application.

Doing this prevents the system from displaying useful information,
though.  The application should attempt to tell the user what went
wrong.

Reinstate the call to SetErrorMode() and try to provide an error
message, at least for the situation mentioned in issue #423 and
other similar cases.

Adds 360-368 bytes.

(GitHub issue #423)

1 files changed, 4 insertions, 0 deletions

diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index 51824f1b3..c90285ae9 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -1349,6 +1349,10 @@ int main(int argc UNUSED_PARAM, char **argv)
                         break;
                 }
         }
+
+        /* Have this process handle critical errors itself:  the default
+         * system-generated error dialogs may be inconvenient. */
+        SetErrorMode(SEM_FAILCRITICALERRORS);
 #endif
 
 #if defined(__MINGW64_VERSION_MAJOR)