Improve the setuid situation a bit, and make it more apparent

when people really ought to make busybox setuid root.
 -Erik

1 files changed, 16 insertions, 0 deletions

diff --git a/loginutils/Config.in b/loginutils/Config.in
index d9938b066..5619aa9af 100644
--- a/loginutils/Config.in
+++ b/loginutils/Config.in
@@ -69,9 +69,13 @@ config CONFIG_FEATURE_U_W_TMP
 config CONFIG_LOGIN
         bool "login"
         default n
+        select CONFIG_FEATURE_SUID
         help
           login is used when signing onto a system.
 
+          Note that Busybox binary must be setuid root for this applet to
+          work properly.
+
 config CONFIG_FEATURE_SECURETTY
         bool "  Support for /etc/securetty"
         default y
@@ -84,19 +88,27 @@ config CONFIG_FEATURE_SECURETTY
 config CONFIG_PASSWD
         bool "passwd"
         default n
+        select CONFIG_FEATURE_SUID
         help
           passwd changes passwords for user and group accounts.  A normal user
           may only change the password for his/her own account, the super user
           may change the password for any account.  The administrator of a group
           may change the password for the group.
 
+          Note that Busybox binary must be setuid root for this applet to
+          work properly.
+
 config CONFIG_SU
         bool "su"
         default n
+        select CONFIG_FEATURE_SUID
         help
           su is used to become another user during a login session.
           Invoked without a username, su defaults to becoming the super user.
 
+          Note that Busybox binary must be setuid root for this applet to
+          work properly.
+
 config CONFIG_SULOGIN
         bool "sulogin"
         default n
@@ -107,9 +119,13 @@ config CONFIG_SULOGIN
 config CONFIG_VLOCK
         bool "vlock"
         default n
+        select CONFIG_FEATURE_SUID
         help
           Build the "vlock" applet which allows you to lock (virtual) terminals.
 
+          Note that Busybox binary must be setuid root for this applet to
+          work properly.
+
 comment "Common options for adduser, deluser, login, su"
         depends on CONFIG_ADDUSER || CONFIG_DELUSER || CONFIG_LOGIN || CONFIG_SU