diff options
| author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-03-17 09:09:09 +0000 |
|---|---|---|
| committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-03-17 09:09:09 +0000 |
| commit | 1d42665b6b0571b9fa5d3b10fbf2dd03382f0ba2 (patch) | |
| tree | 7ec8969fc2b07a2b7dc37f96435e5eddf7daf7fd /miscutils/mt.c | |
| parent | 62a90cdd7435f09f4bb8673e8b7b213067f9d5cc (diff) | |
| download | busybox-w32-1d42665b6b0571b9fa5d3b10fbf2dd03382f0ba2.tar.gz busybox-w32-1d42665b6b0571b9fa5d3b10fbf2dd03382f0ba2.tar.bz2 busybox-w32-1d42665b6b0571b9fa5d3b10fbf2dd03382f0ba2.zip | |
*: shrink: use Vladimir's "o+" specifier instead of xatou(opt_param)
function old new delta
getopt32 1370 1385 +15
sulogin_main 490 494 +4
realpath_main 84 86 +2
sleep_main 76 77 +1
mt_main 256 257 +1
printenv_main 75 74 -1
fdformat_main 546 545 -1
usleep_main 44 42 -2
setlogcons_main 77 75 -2
ed_main 2654 2649 -5
deallocvt_main 69 64 -5
addgroup_main 373 368 -5
mkfs_minix_main 2989 2982 -7
tail_main 1221 1213 -8
sv_main 1254 1241 -13
du_main 348 328 -20
tftp_main 325 302 -23
split_main 581 558 -23
nc_main 1000 977 -23
diff_main 891 868 -23
arping_main 1797 1770 -27
ls_main 893 847 -46
od_main 2797 2750 -47
readprofile_main 1944 1895 -49
tcpudpsvd_main 1973 1922 -51
udhcpc_main 2590 2513 -77
grep_main 824 722 -102
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 5/22 up/down: 23/-560) Total: -537 bytes
text data bss dec hex filename
796973 658 7428 805059 c48c3 busybox_old
796479 662 7420 804561 c46d1 busybox_unstripped
Diffstat (limited to 'miscutils/mt.c')
| -rw-r--r-- | miscutils/mt.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/miscutils/mt.c b/miscutils/mt.c index c16073c61..c56a8e0ca 100644 --- a/miscutils/mt.c +++ b/miscutils/mt.c | |||
| @@ -81,24 +81,22 @@ static const char opcode_name[] ALIGN1 = | |||
| 81 | "weof" "\0"; | 81 | "weof" "\0"; |
| 82 | 82 | ||
| 83 | int mt_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; | 83 | int mt_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
| 84 | int mt_main(int argc, char **argv) | 84 | int mt_main(int argc ATTRIBUTE_UNUSED, char **argv) |
| 85 | { | 85 | { |
| 86 | const char *file = "/dev/tape"; | 86 | const char *file = "/dev/tape"; |
| 87 | struct mtop op; | 87 | struct mtop op; |
| 88 | struct mtpos position; | 88 | struct mtpos position; |
| 89 | int fd, mode, idx; | 89 | int fd, mode, idx; |
| 90 | 90 | ||
| 91 | if (argc < 2) { | 91 | if (!argv[1]) { |
| 92 | bb_show_usage(); | 92 | bb_show_usage(); |
| 93 | } | 93 | } |
| 94 | 94 | ||
| 95 | if (strcmp(argv[1], "-f") == 0) { | 95 | if (strcmp(argv[1], "-f") == 0) { |
| 96 | if (argc < 4) { | 96 | if (!argv[2] || !argv[3]) |
| 97 | bb_show_usage(); | 97 | bb_show_usage(); |
| 98 | } | ||
| 99 | file = argv[2]; | 98 | file = argv[2]; |
| 100 | argv += 2; | 99 | argv += 2; |
| 101 | argc -= 2; | ||
| 102 | } | 100 | } |
| 103 | 101 | ||
| 104 | idx = index_in_strings(opcode_name, argv[1]); | 102 | idx = index_in_strings(opcode_name, argv[1]); |
| @@ -107,7 +105,7 @@ int mt_main(int argc, char **argv) | |||
| 107 | bb_error_msg_and_die("unrecognized opcode %s", argv[1]); | 105 | bb_error_msg_and_die("unrecognized opcode %s", argv[1]); |
| 108 | 106 | ||
| 109 | op.mt_op = opcode_value[idx]; | 107 | op.mt_op = opcode_value[idx]; |
| 110 | if (argc >= 3) | 108 | if (argv[2]) |
| 111 | op.mt_count = xatoi_u(argv[2]); | 109 | op.mt_count = xatoi_u(argv[2]); |
| 112 | else | 110 | else |
| 113 | op.mt_count = 1; /* One, not zero, right? */ | 111 | op.mt_count = 1; /* One, not zero, right? */ |