random s/short/int/

add_cmd                                             1189    1190      +1
xconnect_ftpdata                                     118     117      -1
data_align                                            86      84      -2
process_files                                       2101    2096      -5
forkexec                                            1345    1334     -11

1 files changed, 3 insertions, 2 deletions

diff --git a/networking/httpd.c b/networking/httpd.c
index 779f070d9..1ac49e7a2 100644
--- a/networking/httpd.c
+++ b/networking/httpd.c
@@ -1409,10 +1409,11 @@ static void send_cgi_and_exit(
                 /* Child process */
                 xfunc_error_retval = 242;
 
+                /* NB: close _first_, then move fds! */
+                close(toCgi.wr);
+                close(fromCgi.rd);
                 xmove_fd(toCgi.rd, 0);  /* replace stdin with the pipe */
                 xmove_fd(fromCgi.wr, 1);  /* replace stdout with the pipe */
-                close(fromCgi.rd);
-                close(toCgi.wr);
                 /* User seeing stderr output can be a security problem.
                  * If CGI really wants that, it can always do dup itself. */
                 /* dup2(1, 2); */