diff options
| author | Denis Vlasenko <vda.linux@googlemail.com> | 2007-06-04 10:16:52 +0000 |
|---|---|---|
| committer | Denis Vlasenko <vda.linux@googlemail.com> | 2007-06-04 10:16:52 +0000 |
| commit | 74324c86663f57a19c1de303ee8c8e5449db9ef2 (patch) | |
| tree | 11f5da9de4212875ce5811be2e1050e076378c9a /networking/nc.c | |
| parent | 4e5f82c76f08614d0b69f9ec4a8baac303af15f6 (diff) | |
| download | busybox-w32-74324c86663f57a19c1de303ee8c8e5449db9ef2.tar.gz busybox-w32-74324c86663f57a19c1de303ee8c8e5449db9ef2.tar.bz2 busybox-w32-74324c86663f57a19c1de303ee8c8e5449db9ef2.zip | |
Audit bb_common_bufsiz usage, add script which looks for misuse.
tr: stop using globals needlessly.
code: -103 bytes
Diffstat (limited to 'networking/nc.c')
| -rw-r--r-- | networking/nc.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/networking/nc.c b/networking/nc.c index 1fb38f83c..e7bd519e0 100644 --- a/networking/nc.c +++ b/networking/nc.c | |||
| @@ -174,11 +174,10 @@ int nc_main(int argc, char **argv) | |||
| 174 | if (select(FD_SETSIZE, &testfds, NULL, NULL, NULL) < 0) | 174 | if (select(FD_SETSIZE, &testfds, NULL, NULL, NULL) < 0) |
| 175 | bb_perror_msg_and_die("select"); | 175 | bb_perror_msg_and_die("select"); |
| 176 | 176 | ||
| 177 | #define iobuf bb_common_bufsiz1 | ||
| 177 | for (fd = 0; fd < FD_SETSIZE; fd++) { | 178 | for (fd = 0; fd < FD_SETSIZE; fd++) { |
| 178 | if (FD_ISSET(fd, &testfds)) { | 179 | if (FD_ISSET(fd, &testfds)) { |
| 179 | nread = safe_read(fd, bb_common_bufsiz1, | 180 | nread = safe_read(fd, iobuf, sizeof(iobuf)); |
| 180 | sizeof(bb_common_bufsiz1)); | ||
| 181 | |||
| 182 | if (fd == cfd) { | 181 | if (fd == cfd) { |
| 183 | if (nread < 1) | 182 | if (nread < 1) |
| 184 | exit(0); | 183 | exit(0); |
| @@ -192,8 +191,7 @@ int nc_main(int argc, char **argv) | |||
| 192 | } | 191 | } |
| 193 | ofd = cfd; | 192 | ofd = cfd; |
| 194 | } | 193 | } |
| 195 | 194 | xwrite(ofd, iobuf, nread); | |
| 196 | xwrite(ofd, bb_common_bufsiz1, nread); | ||
| 197 | if (delay > 0) sleep(delay); | 195 | if (delay > 0) sleep(delay); |
| 198 | } | 196 | } |
| 199 | } | 197 | } |