libbb: reduce the overhead of single parameter bb_error_msg() calls

Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().

This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.

Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.

This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.

The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):

Arm:     -92 bytes
MIPS:    -52 bytes
PPC:   -1836 bytes
x86_64: -938 bytes

Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.

Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

1 files changed, 7 insertions, 7 deletions

diff --git a/networking/tls.c b/networking/tls.c
index db7be07f3..854937302 100644
--- a/networking/tls.c
+++ b/networking/tls.c
@@ -446,7 +446,7 @@ static void hmac_begin(hmac_precomputed_t *pre, uint8_t *key, unsigned key_size,
         // than INSIZE bytes will first hash the key using H and then use the
         // resultant OUTSIZE byte string as the actual key to HMAC."
         if (key_size > SHA_INSIZE) {
-                bb_error_msg_and_die("HMAC key>64"); //does not happen (yet?)
+                bb_simple_error_msg_and_die("HMAC key>64"); //does not happen (yet?)
 //              md5sha_ctx_t ctx;
 //              begin(&ctx);
 //              md5sha_hash(&ctx, key, key_size);
@@ -1132,7 +1132,7 @@ static int tls_xread_record(tls_state_t *tls, const char *expected)
                 }
         }
         if (sz < 0)
-                bb_error_msg_and_die("encrypted data too short");
+                bb_simple_error_msg_and_die("encrypted data too short");
 
         //dump_hex("<< %s\n", tls->inbuf, RECHDR_LEN + sz);
 
@@ -1411,7 +1411,7 @@ static void find_key_in_der_cert(tls_state_t *tls, uint8_t *der, int len)
                         dbg("ECDSA key\n");
                         //UNUSED: tls->flags |= GOT_CERT_ECDSA_KEY_ALG;
                 } else
-                        bb_error_msg_and_die("not RSA or ECDSA cert");
+                        bb_simple_error_msg_and_die("not RSA or ECDSA cert");
         }
 
         if (tls->flags & GOT_CERT_RSA_KEY_ALG) {
@@ -1882,7 +1882,7 @@ static void process_server_key(tls_state_t *tls, int len)
         /* So far we only support curve_x25519 */
         move_from_unaligned32(t32, keybuf);
         if (t32 != htonl(0x03001d20))
-                bb_error_msg_and_die("elliptic curve is not x25519");
+                bb_simple_error_msg_and_die("elliptic curve is not x25519");
 
         memcpy(tls->hsd->ecc_pub_key32, keybuf + 4, 32);
         tls->flags |= GOT_EC_KEY;
@@ -1929,7 +1929,7 @@ static void send_client_key_exchange(tls_state_t *tls)
         if (!(tls->flags & NEED_EC_KEY)) {
                 /* RSA */
                 if (!(tls->flags & GOT_CERT_RSA_KEY_ALG))
-                        bb_error_msg("server cert is not RSA");
+                        bb_simple_error_msg("server cert is not RSA");
 
                 tls_get_random(rsa_premaster, sizeof(rsa_premaster));
                 if (TLS_DEBUG_FIXED_SECRETS)
@@ -1959,7 +1959,7 @@ static void send_client_key_exchange(tls_state_t *tls)
                 uint8_t privkey[CURVE25519_KEYSIZE]; //[32]
 
                 if (!(tls->flags & GOT_EC_KEY))
-                        bb_error_msg("server did not provide EC key");
+                        bb_simple_error_msg("server did not provide EC key");
 
                 /* Generate random private key, see RFC 7748 */
                 tls_get_random(privkey, sizeof(privkey));
@@ -2322,7 +2322,7 @@ void FAST_FUNC tls_run_copy_loop(tls_state_t *tls, unsigned flags)
                 int nread;
 
                 if (safe_poll(pfds, 2, -1) < 0)
-                        bb_perror_msg_and_die("poll");
+                        bb_simple_perror_msg_and_die("poll");
 
                 if (pfds[0].revents) {
                         void *buf;