diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2017-09-29 14:09:02 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2017-09-29 14:22:43 +0200 |
commit | 2b9acc60c0468379cd24d13bc9e3f3e50761c0c9 (patch) | |
tree | cc210e6cc6c63605bd7100ec3f516b62416b1f4e /networking/udhcp/dhcpc.c | |
parent | 0c4dbd481aedb5d22c1048e7f7eb547a3b5e50a5 (diff) | |
download | busybox-w32-2b9acc60c0468379cd24d13bc9e3f3e50761c0c9.tar.gz busybox-w32-2b9acc60c0468379cd24d13bc9e3f3e50761c0c9.tar.bz2 busybox-w32-2b9acc60c0468379cd24d13bc9e3f3e50761c0c9.zip |
udhcpc[6]: initialize entire sockaddr_ll
I see random field values like sll_hatype=0x267 when I strace.
They seem to not matter, but just in case they sometimes do,
let's at least have deterministic values (via memset(0)).
function old new delta
change_listen_mode 308 322 +14
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'networking/udhcp/dhcpc.c')
-rw-r--r-- | networking/udhcp/dhcpc.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c index 99d91bf70..6c74996ef 100644 --- a/networking/udhcp/dhcpc.c +++ b/networking/udhcp/dhcpc.c | |||
@@ -1010,9 +1010,14 @@ static int udhcp_raw_socket(int ifindex) | |||
1010 | */ | 1010 | */ |
1011 | log2("got raw socket fd"); | 1011 | log2("got raw socket fd"); |
1012 | 1012 | ||
1013 | memset(&sock, 0, sizeof(sock)); /* let's be deterministic */ | ||
1013 | sock.sll_family = AF_PACKET; | 1014 | sock.sll_family = AF_PACKET; |
1014 | sock.sll_protocol = htons(ETH_P_IP); | 1015 | sock.sll_protocol = htons(ETH_P_IP); |
1015 | sock.sll_ifindex = ifindex; | 1016 | sock.sll_ifindex = ifindex; |
1017 | /*sock.sll_hatype = ARPHRD_???;*/ | ||
1018 | /*sock.sll_pkttype = PACKET_???;*/ | ||
1019 | /*sock.sll_halen = ???;*/ | ||
1020 | /*sock.sll_addr[8] = ???;*/ | ||
1016 | xbind(fd, (struct sockaddr *) &sock, sizeof(sock)); | 1021 | xbind(fd, (struct sockaddr *) &sock, sizeof(sock)); |
1017 | 1022 | ||
1018 | #if 0 /* Several users reported breakage when BPF filter is used */ | 1023 | #if 0 /* Several users reported breakage when BPF filter is used */ |