win32: consolidate executable handling in popen.c

Commit f444dc586 (win32: only search PATH for compressor) made
mingw_fork_compressor() perform a PATH lookup for the xz and lzma
compression programs.  This avoided relying on CreateProcess() to
perform the search.

Other callers of the pipe creation code should also avoid reliance
on CreateProcess's executable search:

- Move the applet test and PATH lookup into mingw_popen_internal().
  The first argument to CreateProcess() will always be a path to
  an executable.

- mingw_fork_compressor() uses the new "w+" mode to indicate that
  xz and lzma compressors should be found on PATH.

- mingw_popen() no longer needs to check for an applet itself, as
  that's now handled in mingw_popen_internal().

- spawn_ssl_client() in 'wget' can rely on the popen code to look
  up the 'ssl_client' applet.

- Remove unnecessary argument checks in mingw_popen_internal().

Adds 0-24 bytes.

1 files changed, 2 insertions, 3 deletions

diff --git a/networking/wget.c b/networking/wget.c
index f3c0c89f3..b01304897 100644
--- a/networking/wget.c
+++ b/networking/wget.c
@@ -839,12 +839,11 @@ static void spawn_ssl_client(const char *host, int network_fd, int flags)
 
         fflush_all();
 
-        cmd = xasprintf("%s --busybox ssl_client -h %p -n %s%s",
-                                        bb_busybox_exec_path,
+        cmd = xasprintf("ssl_client -h %p -n %s%s",
                                         (void *)_get_osfhandle(network_fd), servername,
                                         flags & TLSLOOP_EXIT_ON_LOCAL_EOF ? " -e" : "");
 
-        if ( (fd1=mingw_popen_fd(NULL, cmd, "b", -1, NULL)) == -1 ) {
+        if ((fd1=mingw_popen_fd("ssl_client", cmd, "b", -1, NULL)) == -1) {
                 bb_perror_msg_and_die("can't execute ssl_client");
         }