aboutsummaryrefslogtreecommitdiff
path: root/networking
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2010-01-04 14:15:38 +0100
committerDenys Vlasenko <vda.linux@googlemail.com>2010-01-04 14:15:38 +0100
commit2ec91aead52d6ea6a42420005119ebb281a76cdc (patch)
tree115804c56ff172f96c0138bcabcc7d5e56e5dae0 /networking
parenta355da07756e529c112249653ed5af0e2d910728 (diff)
downloadbusybox-w32-2ec91aead52d6ea6a42420005119ebb281a76cdc.tar.gz
busybox-w32-2ec91aead52d6ea6a42420005119ebb281a76cdc.tar.bz2
busybox-w32-2ec91aead52d6ea6a42420005119ebb281a76cdc.zip
*: remove some uses of argc
function old new delta whoami_main 34 37 +3 logname_main 60 63 +3 hostid_main 35 38 +3 ttysize_main 136 135 -1 nmeter_main 673 672 -1 logger_main 387 386 -1 uuencode_main 330 328 -2 ifupdown_main 2125 2123 -2 mesg_main 158 155 -3 free_main 333 330 -3 cal_main 902 899 -3 acpid_main 443 440 -3 ar_main 196 189 -7 find_main 476 467 -9 ifconfig_main 1235 1221 -14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/12 up/down: 9/-49) Total: -40 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'networking')
-rw-r--r--networking/ifconfig.c10
-rw-r--r--networking/ifupdown.c7
-rw-r--r--networking/nc_bloaty.c3
-rw-r--r--networking/zcip.c3
4 files changed, 10 insertions, 13 deletions
diff --git a/networking/ifconfig.c b/networking/ifconfig.c
index 863d6e44a..1e960d45c 100644
--- a/networking/ifconfig.c
+++ b/networking/ifconfig.c
@@ -260,7 +260,7 @@ static int in_ether(const char *bufp, struct sockaddr *sap);
260 * Our main function. 260 * Our main function.
261 */ 261 */
262int ifconfig_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; 262int ifconfig_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
263int ifconfig_main(int argc, char **argv) 263int ifconfig_main(int argc UNUSED_PARAM, char **argv)
264{ 264{
265 struct ifreq ifr; 265 struct ifreq ifr;
266 struct sockaddr_in sai; 266 struct sockaddr_in sai;
@@ -291,19 +291,17 @@ int ifconfig_main(int argc, char **argv)
291 291
292 /* skip argv[0] */ 292 /* skip argv[0] */
293 ++argv; 293 ++argv;
294 --argc;
295 294
296#if ENABLE_FEATURE_IFCONFIG_STATUS 295#if ENABLE_FEATURE_IFCONFIG_STATUS
297 if (argc > 0 && (argv[0][0] == '-' && argv[0][1] == 'a' && !argv[0][2])) { 296 if (argv[0] && (argv[0][0] == '-' && argv[0][1] == 'a' && !argv[0][2])) {
298 interface_opt_a = 1; 297 interface_opt_a = 1;
299 --argc;
300 ++argv; 298 ++argv;
301 } 299 }
302#endif 300#endif
303 301
304 if (argc <= 1) { 302 if (!argv[0] || !argv[1]) { /* one or no args */
305#if ENABLE_FEATURE_IFCONFIG_STATUS 303#if ENABLE_FEATURE_IFCONFIG_STATUS
306 return display_interfaces(argc ? *argv : NULL); 304 return display_interfaces(argv[0] /* can be NULL */);
307#else 305#else
308 bb_error_msg_and_die("no support for status display"); 306 bb_error_msg_and_die("no support for status display");
309#endif 307#endif
diff --git a/networking/ifupdown.c b/networking/ifupdown.c
index d28c0b867..51b36263f 100644
--- a/networking/ifupdown.c
+++ b/networking/ifupdown.c
@@ -1142,7 +1142,7 @@ static llist_t *read_iface_state(void)
1142 1142
1143 1143
1144int ifupdown_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; 1144int ifupdown_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
1145int ifupdown_main(int argc, char **argv) 1145int ifupdown_main(int argc UNUSED_PARAM, char **argv)
1146{ 1146{
1147 int (*cmds)(struct interface_defn_t *); 1147 int (*cmds)(struct interface_defn_t *);
1148 struct interfaces_file_t *defn; 1148 struct interfaces_file_t *defn;
@@ -1161,7 +1161,8 @@ int ifupdown_main(int argc, char **argv)
1161 } 1161 }
1162 1162
1163 getopt32(argv, OPTION_STR, &interfaces); 1163 getopt32(argv, OPTION_STR, &interfaces);
1164 if (argc - optind > 0) { 1164 argv += optind;
1165 if (argv[0]) {
1165 if (DO_ALL) bb_show_usage(); 1166 if (DO_ALL) bb_show_usage();
1166 } else { 1167 } else {
1167 if (!DO_ALL) bb_show_usage(); 1168 if (!DO_ALL) bb_show_usage();
@@ -1175,7 +1176,7 @@ int ifupdown_main(int argc, char **argv)
1175 if (DO_ALL) { 1176 if (DO_ALL) {
1176 target_list = defn->autointerfaces; 1177 target_list = defn->autointerfaces;
1177 } else { 1178 } else {
1178 llist_add_to_end(&target_list, argv[optind]); 1179 llist_add_to_end(&target_list, argv[0]);
1179 } 1180 }
1180 1181
1181 /* Update the interfaces */ 1182 /* Update the interfaces */
diff --git a/networking/nc_bloaty.c b/networking/nc_bloaty.c
index ad98bed30..9d7c23dee 100644
--- a/networking/nc_bloaty.c
+++ b/networking/nc_bloaty.c
@@ -673,7 +673,7 @@ Debug("wrote %d to net, errno %d", rr, errno);
673 673
674/* main: now we pull it all together... */ 674/* main: now we pull it all together... */
675int nc_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; 675int nc_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
676int nc_main(int argc, char **argv) 676int nc_main(int argc UNUSED_PARAM, char **argv)
677{ 677{
678 char *str_p, *str_s; 678 char *str_p, *str_s;
679 IF_NC_EXTRA(char *str_i, *str_o;) 679 IF_NC_EXTRA(char *str_i, *str_o;)
@@ -702,7 +702,6 @@ int nc_main(int argc, char **argv)
702 while (*++proggie) { 702 while (*++proggie) {
703 if (strcmp(*proggie, "-e") == 0) { 703 if (strcmp(*proggie, "-e") == 0) {
704 *proggie = NULL; 704 *proggie = NULL;
705 argc = proggie - argv;
706 proggie++; 705 proggie++;
707 goto e_found; 706 goto e_found;
708 } 707 }
diff --git a/networking/zcip.c b/networking/zcip.c
index df4c0ec2d..a4da5cbcd 100644
--- a/networking/zcip.c
+++ b/networking/zcip.c
@@ -182,7 +182,7 @@ static ALWAYS_INLINE unsigned random_delay_ms(unsigned secs)
182 * main program 182 * main program
183 */ 183 */
184int zcip_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; 184int zcip_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
185int zcip_main(int argc, char **argv) 185int zcip_main(int argc UNUSED_PARAM, char **argv)
186{ 186{
187 int state; 187 int state;
188 char *r_opt; 188 char *r_opt;
@@ -241,7 +241,6 @@ int zcip_main(int argc, char **argv)
241 bb_error_msg_and_die("invalid link address"); 241 bb_error_msg_and_die("invalid link address");
242 } 242 }
243 } 243 }
244 argc -= optind;
245 argv += optind - 1; 244 argv += optind - 1;
246 245
247 /* Now: argv[0]:junk argv[1]:intf argv[2]:script argv[3]:NULL */ 246 /* Now: argv[0]:junk argv[1]:intf argv[2]:script argv[3]:NULL */