Merge commit '1_19_4' into merge_1_19

3 files changed, 16 insertions, 7 deletions

diff --git a/networking/inetd.c b/networking/inetd.c
index 873fd9528..05ad8c792 100644
--- a/networking/inetd.c
+++ b/networking/inetd.c
@@ -1278,6 +1278,7 @@ int inetd_main(int argc UNUSED_PARAM, char **argv)
                                                         sep->se_count = 0;
                                                         rearm_alarm(); /* will revive it in RETRYTIME sec */
                                                         restore_sigmask(&omask);
+                                                        maybe_close(new_udp_fd);
                                                         maybe_close(accepted_fd);
                                                         continue; /* -> check next fd in fd set */
                                                 }
@@ -1298,17 +1299,18 @@ int inetd_main(int argc UNUSED_PARAM, char **argv)
                                         bb_perror_msg("vfork"+1);
                                         sleep(1);
                                         restore_sigmask(&omask);
+                                        maybe_close(new_udp_fd);
                                         maybe_close(accepted_fd);
                                         continue; /* -> check next fd in fd set */
                                 }
                                 if (pid == 0)
                                         pid--; /* -1: "we did fork and we are child" */
                         }
-                        /* if pid == 0 here, we never forked */
+                        /* if pid == 0 here, we didn't fork */
 
                         if (pid > 0) { /* parent */
                                 if (sep->se_wait) {
-                                        /* tcp wait: we passed listening socket to child,
+                                        /* wait: we passed socket to child,
                                          * will wait for child to terminate */
                                         sep->se_wait = pid;
                                         remove_fd_from_set(sep->se_fd);
@@ -1345,9 +1347,13 @@ int inetd_main(int argc UNUSED_PARAM, char **argv)
                         setsid();
                         /* "nowait" udp */
                         if (new_udp_fd >= 0) {
-                                len_and_sockaddr *lsa = xzalloc_lsa(sep->se_family);
+                                len_and_sockaddr *lsa;
+                                int r;
+
+                                close(new_udp_fd);
+                                lsa = xzalloc_lsa(sep->se_family);
                                 /* peek at the packet and remember peer addr */
-                                int r = recvfrom(ctrl, NULL, 0, MSG_PEEK|MSG_DONTWAIT,
+                                r = recvfrom(ctrl, NULL, 0, MSG_PEEK|MSG_DONTWAIT,
                                         &lsa->u.sa, &lsa->len);
                                 if (r < 0)
                                         goto do_exit1;
diff --git a/networking/tftp.c b/networking/tftp.c
index 17485a527..043b879af 100644
--- a/networking/tftp.c
+++ b/networking/tftp.c
@@ -813,7 +813,8 @@ int tftpd_main(int argc UNUSED_PARAM, char **argv)
                 goto err;
         }
         mode = local_file + strlen(local_file) + 1;
-        if (mode >= block_buf + result || strcmp(mode, "octet") != 0) {
+        /* RFC 1350 says mode string is case independent */
+        if (mode >= block_buf + result || strcasecmp(mode, "octet") != 0) {
                 goto err;
         }
 # if ENABLE_FEATURE_TFTP_BLOCKSIZE
diff --git a/networking/wget.c b/networking/wget.c
index eca673a86..24b0d93c8 100644
--- a/networking/wget.c
+++ b/networking/wget.c
@@ -552,6 +552,7 @@ static void download_one_url(const char *url)
         FILE *dfp;                      /* socket to ftp server (data)      */
         char *proxy = NULL;
         char *fname_out_alloc;
+        char *redirected_path = NULL;
         struct host_info server;
         struct host_info target;
 
@@ -794,8 +795,8 @@ However, in real world it was observed that some web servers
                                         bb_error_msg_and_die("too many redirections");
                                 fclose(sfp);
                                 if (str[0] == '/') {
-                                        free(target.allocated);
-                                        target.path = target.allocated = xstrdup(str+1);
+                                        free(redirected_path);
+                                        target.path = redirected_path = xstrdup(str+1);
                                         /* lsa stays the same: it's on the same server */
                                 } else {
                                         parse_url(str, &target);
@@ -850,6 +851,7 @@ However, in real world it was observed that some web servers
         free(server.allocated);
         free(target.allocated);
         free(fname_out_alloc);
+        free(redirected_path);
 }
 
 int wget_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;