PID should be stored in pid_t, not int or long.

find_pid_by_name() was returning 0 or -1 in last array element,
but -1 was never checked. We can use just 0 intead.

1 files changed, 4 insertions, 4 deletions

diff --git a/procps/ps.c b/procps/ps.c
index 97e239b07..df4dcc4fc 100644
--- a/procps/ps.c
+++ b/procps/ps.c
@@ -58,7 +58,7 @@ int ps_main(int argc, char **argv)
                         len = sizeof(sbuf);
 
                         if (is_selinux_enabled()) {
-                                if (getpidcon(p->pid,&sid) < 0)
+                                if (getpidcon(p->pid, &sid) < 0)
                                         sid = NULL;
                         }
 
@@ -71,14 +71,14 @@ int ps_main(int argc, char **argv)
                         } else {
                                 safe_strncpy(sbuf, "unknown", 7);
                         }
-                        len = printf("%5d %-32s %s ", p->pid, sbuf, p->state);
+                        len = printf("%5u %-32s %s ", (unsigned)p->pid, sbuf, p->state);
                 }
                 else
 #endif
                         if (p->rss == 0)
-                                len = printf("%5d %-8s        %s ", p->pid, p->user, p->state);
+                                len = printf("%5u %-8s        %s ", (unsigned)p->pid, p->user, p->state);
                         else
-                                len = printf("%5d %-8s %6ld %s ", p->pid, p->user, p->rss, p->state);
+                                len = printf("%5u %-8s %6ld %s ", (unsigned)p->pid, p->user, p->rss, p->state);
 
                 i = terminal_width-len;