If find_pid_by_name() had an error, it was returning -1, but storing

that into a pid_t, which is unsigned on a number archs.  Furthermore,
find_pid_by_name() would _never_ return an error if the intended proces
was "init", but instead would return 1, meaning we would fail to work
on 2.4.x kernels running an initrd...
 -Erik

2 files changed, 2 insertions, 2 deletions

diff --git a/procps/kill.c b/procps/kill.c
index 8b8a9922c..7147b5727 100644
--- a/procps/kill.c
+++ b/procps/kill.c
@@ -114,7 +114,7 @@ extern int kill_main(int argc, char **argv)
                 pid_t myPid=getpid();
                 /* Looks like they want to do a killall.  Do that */
                 while (--argc >= 0) {
-                        pid_t* pidList;
+                        long* pidList;
 
                         pidList = find_pid_by_name( *argv);
                         if (!pidList || *pidList<=0) {
diff --git a/procps/pidof.c b/procps/pidof.c
index 5a40288dc..941582704 100644
--- a/procps/pidof.c
+++ b/procps/pidof.c
@@ -58,7 +58,7 @@ extern int pidof_main(int argc, char **argv)
 
         /* Looks like everything is set to go. */
         while(optind < argc) {
-                pid_t* pidList;
+                long* pidList;
 
                 pidList = find_pid_by_name( argv[optind]);
                 if (!pidList || *pidList<=0) {