diff options
author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-01-02 19:55:04 +0000 |
---|---|---|
committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-01-02 19:55:04 +0000 |
commit | fb0eba706cccd510d99c4c5339a76dd15bc8a628 (patch) | |
tree | 45122b93a1a5d628e4aa146251e34397094de817 /runit/svlogd.c | |
parent | 27963980dbe1262fd6c447fc7d06839aea0861bc (diff) | |
download | busybox-w32-fb0eba706cccd510d99c4c5339a76dd15bc8a628.tar.gz busybox-w32-fb0eba706cccd510d99c4c5339a76dd15bc8a628.tar.bz2 busybox-w32-fb0eba706cccd510d99c4c5339a76dd15bc8a628.zip |
libbb: introduce and use safe_waitpid (loops in EINTR)
*: use more approproate (shorter) versions of wait()
function old new delta
safe_waitpid - 48 +48
wait_any_nohang - 17 +17
send_tree 365 369 +4
processorstop 432 435 +3
text_yank 110 108 -2
make_human_readable_str 202 200 -2
crond_main 1368 1366 -2
handle_sigchld 49 43 -6
reapchild 166 159 -7
custom 260 250 -10
checkscript 191 177 -14
wait_nohang 17 - -17
wait_pid 43 - -43
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 2/7 up/down: 72/-103) Total: -31 bytes
Diffstat (limited to 'runit/svlogd.c')
-rw-r--r-- | runit/svlogd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/runit/svlogd.c b/runit/svlogd.c index 2dc8cb987..1d679c972 100644 --- a/runit/svlogd.c +++ b/runit/svlogd.c | |||
@@ -265,7 +265,7 @@ static unsigned processorstop(struct logdir *ld) | |||
265 | 265 | ||
266 | if (ld->ppid) { | 266 | if (ld->ppid) { |
267 | sig_unblock(SIGHUP); | 267 | sig_unblock(SIGHUP); |
268 | while (wait_pid(&wstat, ld->ppid) == -1) | 268 | while (safe_waitpid(ld->ppid, &wstat, 0) == -1) |
269 | pause2cannot("wait for processor", ld->name); | 269 | pause2cannot("wait for processor", ld->name); |
270 | sig_block(SIGHUP); | 270 | sig_block(SIGHUP); |
271 | ld->ppid = 0; | 271 | ld->ppid = 0; |
@@ -794,7 +794,7 @@ static void sig_child_handler(int sig_no) | |||
794 | 794 | ||
795 | if (verbose) | 795 | if (verbose) |
796 | bb_error_msg(INFO"sig%s received", "child"); | 796 | bb_error_msg(INFO"sig%s received", "child"); |
797 | while ((pid = wait_nohang(&wstat)) > 0) { | 797 | while ((pid = wait_any_nohang(&wstat)) > 0) { |
798 | for (l = 0; l < dirn; ++l) { | 798 | for (l = 0; l < dirn; ++l) { |
799 | if (dir[l].ppid == pid) { | 799 | if (dir[l].ppid == pid) { |
800 | dir[l].ppid = 0; | 800 | dir[l].ppid = 0; |