diff options
author | Christian Eggers <ceggers@arri.de> | 2020-06-29 17:57:24 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2020-07-31 18:42:30 +0200 |
commit | 39925026f6857979cbe603efd42073eb63f8d9de (patch) | |
tree | ee64a83ed44f4ba4a34bd869e0a4c282163981bb /shell/shell_common.c | |
parent | a088da4476012e067a9a49de997031ea64ac401e (diff) | |
download | busybox-w32-39925026f6857979cbe603efd42073eb63f8d9de.tar.gz busybox-w32-39925026f6857979cbe603efd42073eb63f8d9de.tar.bz2 busybox-w32-39925026f6857979cbe603efd42073eb63f8d9de.zip |
shell: Fix "read -d ''" behavior
With bash's read builtin it is possible to read from a file (e.g.
device-tree) until the first '\0' character:
IFS= read -r -d '' VARIABLE < file
In busybox ash the -d extension is also implemented, but checking the
read character for '\0' has to be performed after comparing with the
delimiter.
Signed-off-by: Christian Eggers <ceggers@arri.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'shell/shell_common.c')
-rw-r--r-- | shell/shell_common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/shell/shell_common.c b/shell/shell_common.c index 12c4a073c..42c4c9c97 100644 --- a/shell/shell_common.c +++ b/shell/shell_common.c | |||
@@ -209,8 +209,6 @@ shell_builtin_read(struct builtin_read_params *params) | |||
209 | } | 209 | } |
210 | 210 | ||
211 | c = buffer[bufpos]; | 211 | c = buffer[bufpos]; |
212 | if (c == '\0') | ||
213 | continue; | ||
214 | if (!(read_flags & BUILTIN_READ_RAW)) { | 212 | if (!(read_flags & BUILTIN_READ_RAW)) { |
215 | if (backslash) { | 213 | if (backslash) { |
216 | backslash = 0; | 214 | backslash = 0; |
@@ -225,6 +223,8 @@ shell_builtin_read(struct builtin_read_params *params) | |||
225 | } | 223 | } |
226 | if (c == delim) /* '\n' or -d CHAR */ | 224 | if (c == delim) /* '\n' or -d CHAR */ |
227 | break; | 225 | break; |
226 | if (c == '\0') | ||
227 | continue; | ||
228 | 228 | ||
229 | /* $IFS splitting. NOT done if we run "read" | 229 | /* $IFS splitting. NOT done if we run "read" |
230 | * without variable names (bash compat). | 230 | * without variable names (bash compat). |