mdev: microscopic enhancement, should change nothing

1 files changed, 6 insertions, 8 deletions

diff --git a/util-linux/mdev.c b/util-linux/mdev.c
index cc729e72a..d1b2684bc 100644
--- a/util-linux/mdev.c
+++ b/util-linux/mdev.c
@@ -178,17 +178,15 @@ static void make_device(char *path, int delete)
                 if (ENABLE_FEATURE_MDEV_CONF) chown(device_name, uid, gid);
         }
         if (command) {
-                int rc;
-                char *s;
-
-                s = xasprintf("MDEV=%s", device_name);
-                putenv(s);
-                rc = system(command);
-                s[4] = 0;
+                /* setenv will leak memory, so use putenv */
+                char *s = xasprintf("MDEV=%s", device_name);
                 putenv(s);
+                if (system(command) == -1)
+                        bb_perror_msg_and_die("cannot run %s", command);
+                s[4] = '\0';
+                unsetenv(s);
                 free(s);
                 free(command);
-                if (rc == -1) bb_perror_msg_and_die("cannot run %s", command);
         }
         if (delete) unlink(device_name);
 }