diff options
author | Denys Vlasenko <vda.linux@googlemail.com> | 2020-10-01 21:52:16 +0200 |
---|---|---|
committer | Denys Vlasenko <vda.linux@googlemail.com> | 2020-10-01 21:52:16 +0200 |
commit | 689d0650ab63425adaea26afe347015a204958ee (patch) | |
tree | 9c2e10b952cad6804359bc10ccc963ff138fc3d4 /util-linux/volume_id | |
parent | 3c3928fc658bddacd4e540589868bc28a8e4ca0a (diff) | |
download | busybox-w32-689d0650ab63425adaea26afe347015a204958ee.tar.gz busybox-w32-689d0650ab63425adaea26afe347015a204958ee.tar.bz2 busybox-w32-689d0650ab63425adaea26afe347015a204958ee.zip |
libbb: shrink recursive_action() by reducing memory pressure
function old new delta
recursive_action1 - 316 +316
file_action_grep 161 164 +3
add_to_prg_cache_if_socket 202 205 +3
depmod_main 509 511 +2
writeFileToTarball 488 489 +1
parse_module 281 282 +1
fileAction 207 208 +1
act 189 190 +1
add_to_dirlist 65 64 -1
writeTarFile 196 194 -2
uuidcache_init 47 45 -2
uuidcache_check_device 109 107 -2
true_action 8 6 -2
run_parts_main 310 308 -2
netstat_main 534 532 -2
lsusb_main 29 27 -2
lspci_main 45 43 -2
initial_scan 138 136 -2
grep_main 845 843 -2
find_main 482 480 -2
config_file_action 437 435 -2
chmod_main 142 140 -2
dirAction 14 10 -4
diff_main 1544 1540 -4
chown_main 154 148 -6
skip_dir 136 129 -7
dir_act 191 184 -7
recursive_action 453 69 -384
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 7/20 up/down: 328/-439) Total: -111 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'util-linux/volume_id')
-rw-r--r-- | util-linux/volume_id/get_devname.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/util-linux/volume_id/get_devname.c b/util-linux/volume_id/get_devname.c index 34f5d119f..00cfb2826 100644 --- a/util-linux/volume_id/get_devname.c +++ b/util-linux/volume_id/get_devname.c | |||
@@ -102,10 +102,9 @@ uuidcache_addentry(char *device, /*int major, int minor,*/ char *label, char *uu | |||
102 | * add a cache entry for this device. | 102 | * add a cache entry for this device. |
103 | * If device node does not exist, it will be temporarily created. */ | 103 | * If device node does not exist, it will be temporarily created. */ |
104 | static int FAST_FUNC | 104 | static int FAST_FUNC |
105 | uuidcache_check_device(const char *device, | 105 | uuidcache_check_device(struct recursive_state *state UNUSED_PARAM, |
106 | struct stat *statbuf, | 106 | const char *device, |
107 | void *userData UNUSED_PARAM, | 107 | struct stat *statbuf) |
108 | int depth UNUSED_PARAM) | ||
109 | { | 108 | { |
110 | /* note: this check rejects links to devices, among other nodes */ | 109 | /* note: this check rejects links to devices, among other nodes */ |
111 | if (!S_ISBLK(statbuf->st_mode) | 110 | if (!S_ISBLK(statbuf->st_mode) |
@@ -145,12 +144,13 @@ uuidcache_init(int scan_devices) | |||
145 | * This is unacceptably complex. Let's just scan /dev. | 144 | * This is unacceptably complex. Let's just scan /dev. |
146 | * (Maybe add scanning of /sys/block/XXX/dev for devices | 145 | * (Maybe add scanning of /sys/block/XXX/dev for devices |
147 | * somehow not having their /dev/XXX entries created?) */ | 146 | * somehow not having their /dev/XXX entries created?) */ |
148 | if (scan_devices) | 147 | if (scan_devices) { |
149 | recursive_action("/dev", ACTION_RECURSE, | 148 | recursive_action("/dev", ACTION_RECURSE, |
150 | uuidcache_check_device, /* file_action */ | 149 | uuidcache_check_device, /* file_action */ |
151 | NULL, /* dir_action */ | 150 | NULL, /* dir_action */ |
152 | NULL, /* userData */ | 151 | NULL /* userData */ |
153 | 0 /* depth */); | 152 | ); |
153 | } | ||
154 | 154 | ||
155 | return uuidCache; | 155 | return uuidCache; |
156 | } | 156 | } |