win32/regex: fix compile warnings

There are plenty of warnings that were not detected in Git's source
code, due to some warnings being turned off in Git's build by default
(even with DEVELOPER=1).

The warnings fall into three categories:

- constants being tested via `#if <name>` instead of `#ifdef <name>`

- unused function parameters

- one instance of an unnecessarily-shadowing variable

This patch fixes all of them.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

1 files changed, 1 insertions, 1 deletions

diff --git a/win32/regex.c b/win32/regex.c
index 95e5d757a..e40a2ea01 100644
--- a/win32/regex.c
+++ b/win32/regex.c
@@ -81,7 +81,7 @@
 #include "regexec.c"
 
 /* Binary backward compatibility.  */
-#if _LIBC
+#ifdef _LIBC
 # include <shlib-compat.h>
 # if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_3)
 link_warning (re_max_failures, "the 're_max_failures' variable is obsolete and will go away.")