win32: fix regression in chdir(2)

When mingw_chdir() was introduced it canonicalised its argument
(585d17d26).  This had the side effect of making its case match
that of the directory as stored on disk.  Subsequent changes
retained that behaviour for symlinks but not otherwise (69d328022,
b99032390).  This was noted to affect the appearance of the
directory specified by the (undocumented) 'sh -d' option.

Fix the case of non-symlink directories too.

Adds 16-32 bytes.

1 files changed, 9 insertions, 7 deletions

diff --git a/win32/mingw.c b/win32/mingw.c
index d323014b7..87e7ca602 100644
--- a/win32/mingw.c
+++ b/win32/mingw.c
@@ -1767,16 +1767,18 @@ int mingw_mkdir(const char *path, int mode UNUSED_PARAM)
 int mingw_chdir(const char *dirname)
 {
         int ret = -1;
-        const char *realdir = dirname;
+        char *realdir;
 
-        if (is_symlink(dirname)) {
-                realdir = auto_string(xmalloc_realpath(dirname));
-                if (realdir)
-                        fix_path_case((char *)realdir);
-        }
+        if (is_symlink(dirname))
+                realdir = xmalloc_realpath(dirname);
+        else
+                realdir = xstrdup(dirname);
 
-        if (realdir)
+        if (realdir) {
+                fix_path_case(realdir);
                 ret = chdir(realdir);
+        }
+        free(realdir);
 
         return ret;
 }