4 files changed, 43 insertions, 32 deletions

diff --git a/libbb/getopt32.c b/libbb/getopt32.c
index 8fb99b6cc..ee85181cd 100644
--- a/libbb/getopt32.c
+++ b/libbb/getopt32.c
@@ -515,28 +515,6 @@ getopt32(char **argv, const char *applet_opts, ...)
                 }
         }
 
-        /* In case getopt32 was already called:
-         * reset the libc getopt() function, which keeps internal state.
-         *
-         * BSD-derived getopt() functions require that optind be set to 1 in
-         * order to reset getopt() state.  This used to be generally accepted
-         * way of resetting getopt().  However, glibc's getopt()
-         * has additional getopt() state beyond optind, and requires that
-         * optind be set to zero to reset its state.  So the unfortunate state of
-         * affairs is that BSD-derived versions of getopt() misbehave if
-         * optind is set to 0 in order to reset getopt(), and glibc's getopt()
-         * will core dump if optind is set 1 in order to reset getopt().
-         *
-         * More modern versions of BSD require that optreset be set to 1 in
-         * order to reset getopt().   Sigh.  Standards, anyone?
-         */
-#ifdef __GLIBC__
-        optind = 0;
-#else /* BSD style */
-        optind = 1;
-        /* optreset = 1; */
-#endif
-        /* optarg = NULL; opterr = 0; optopt = 0; - do we need this?? */
         pargv = NULL;
 
         /* Note: just "getopt() <= 0" will not work well for
diff --git a/libbb/lineedit.c b/libbb/lineedit.c
index c2c3ea996..1f21866ca 100644
--- a/libbb/lineedit.c
+++ b/libbb/lineedit.c
@@ -1415,7 +1415,8 @@ int FAST_FUNC read_line_input(const char *prompt, char *command, int maxsize, li
         if ((state->flags & SAVE_HISTORY) && state->hist_file)
                 load_history(state->hist_file);
 #endif
-        state->cur_history = state->cnt_history;
+        if (state->flags & DO_HISTORY)
+                state->cur_history = state->cnt_history;
 
         /* prepare before init handlers */
         cmdedit_y = 0;  /* quasireal y, not true if line > xt*yt */
diff --git a/libbb/setup_environment.c b/libbb/setup_environment.c
index 04e333fed..78318ce62 100644
--- a/libbb/setup_environment.c
+++ b/libbb/setup_environment.c
@@ -32,16 +32,16 @@
 
 void FAST_FUNC setup_environment(const char *shell, int clear_env, int change_env, const struct passwd *pw)
 {
+        /* Change the current working directory to be the home directory
+         * of the user */
+        if (chdir(pw->pw_dir)) {
+                xchdir("/");
+                bb_error_msg("can't chdir to home directory '%s'", pw->pw_dir);
+        }
+
         if (clear_env) {
                 const char *term;
 
-                /* Change the current working directory to be the home directory
-                 * of the user */
-                if (chdir(pw->pw_dir)) {
-                        xchdir("/");
-                        bb_error_msg("can't chdir to home directory '%s'", pw->pw_dir);
-                }
-
                 /* Leave TERM unchanged. Set HOME, SHELL, USER, LOGNAME, PATH.
                    Unset all other environment variables.  */
                 term = getenv("TERM");
diff --git a/libbb/vfork_daemon_rexec.c b/libbb/vfork_daemon_rexec.c
index da0dc03e5..17b373cd1 100644
--- a/libbb/vfork_daemon_rexec.c
+++ b/libbb/vfork_daemon_rexec.c
@@ -125,6 +125,7 @@ int FAST_FUNC run_nofork_applet_prime(struct nofork_save_area *old, int applet_n
         int rc, argc;
 
         applet_name = APPLET_NAME(applet_no);
+
         xfunc_error_retval = EXIT_FAILURE;
 
         /* Special flag for xfunc_die(). If xfunc will "die"
@@ -132,7 +133,30 @@ int FAST_FUNC run_nofork_applet_prime(struct nofork_save_area *old, int applet_n
          * die_sleep and longjmp here instead. */
         die_sleep = -1;
 
-        /* option_mask32 = 0; - not needed */
+        /* In case getopt() or getopt32() was already called:
+         * reset the libc getopt() function, which keeps internal state.
+         *
+         * BSD-derived getopt() functions require that optind be set to 1 in
+         * order to reset getopt() state.  This used to be generally accepted
+         * way of resetting getopt().  However, glibc's getopt()
+         * has additional getopt() state beyond optind, and requires that
+         * optind be set to zero to reset its state.  So the unfortunate state of
+         * affairs is that BSD-derived versions of getopt() misbehave if
+         * optind is set to 0 in order to reset getopt(), and glibc's getopt()
+         * will core dump if optind is set 1 in order to reset getopt().
+         *
+         * More modern versions of BSD require that optreset be set to 1 in
+         * order to reset getopt().  Sigh.  Standards, anyone?
+         */
+#ifdef __GLIBC__
+        optind = 0;
+#else /* BSD style */
+        optind = 1;
+        /* optreset = 1; */
+#endif
+        /* optarg = NULL; opterr = 1; optopt = 63; - do we need this too? */
+        /* (values above are what they initialized to in glibc and uclibc) */
+        /* option_mask32 = 0; - not needed, no applet depends on it being 0 */
 
         argc = 1;
         while (argv[argc])
@@ -161,8 +185,16 @@ int FAST_FUNC run_nofork_applet_prime(struct nofork_save_area *old, int applet_n
                         rc = 0;
         }
 
-        /* Restoring globals */
+        /* Restoring some globals */
         restore_nofork_data(old);
+
+        /* Other globals can be simply reset to defaults */
+#ifdef __GLIBC__
+        optind = 0;
+#else /* BSD style */
+        optind = 1;
+#endif
+
         return rc & 0xff; /* don't confuse people with "exitcodes" >255 */
 }