aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* The login applet should always be setuid rootandersen2004-08-261-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9169 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito writes:andersen2004-08-261-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | Hi, I've fixed also the issue of whoami cutting down usernames. This time I cannot send a diff because i don't know if my previous patches will be applied or not, so I send in the whole file. The changes I've made don't affect size but ensure that usernames of whatever lenght are correctly displayed. root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami_orig.o text data bss dec hex filename 102 0 0 102 66 whoami_orig.o root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami.o text data bss dec hex filename 93 0 0 93 5d whoami.o This should be applied even if the other patches aren't as this matches the behaviour of the GNU whoami. Thanks in advance, Ciao, Tito git-svn-id: svn://busybox.net/trunk/busybox@9168 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Save a line or twoandersen2004-08-262-6/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9167 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Vladimir N. Oleynik writes:andersen2004-08-261-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | Ming-Ching, >>No. Here there are no mistakes. >>You using POST metod. >>For get data you should read from stdin CONTENT_LENGTH bytes. >Hower as I posted a little while ago, there is indeed a bug >in POST method if the CONTENT_LENGTH is bigger >than sizeof(wbuf[128]). So if your CGI script is expecting to >read the full CONTENT_LENGTH, it might block forever, >because it will only transfer sizeof(wbuf) to the CGI. Ok, Ok. I should find time to understand with a problem. Try attached patch. --w vodz git-svn-id: svn://busybox.net/trunk/busybox@9166 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito writes:andersen2004-08-269-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hi, I've spent the half night staring at the devilish my_getpwuid and my_getgrgid functions trying to find out a way to avoid actual and future potential buffer overflow problems without breaking existing code. Finally I've found a not intrusive way to do this that surely doesn't break existing code and fixes a couple of problems too. The attached patch: 1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows 2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h. 3) The behaviour of tar, ls and logger is unchanged. 4) The behavior of ps with somewhat longer usernames messing up output is fixed. 5) The only bigger change was the increasing of size of the buffers in id.c to avoid false negatives (unknown user: xxxxxx) with usernames longer than 8 chars. The value i used ( 32 chars ) was taken from the tar header ( see gname and uname). Maybe this buffers can be reduced a bit ( to 16 or whatever ), this is up to you. 6) The increase of size of the binary is not so dramatic: size busybox text data bss dec hex filename 239568 2300 36816 278684 4409c busybox size busybox_fixed text data bss dec hex filename 239616 2300 36816 278732 440cc busybox 7) The behaviour of whoami changed: actually it prints out an username cut down to the size of the buffer. This could be fixed by increasing the size of the buffer as in id.c or avoid the use of my_getpwuid and use getpwuid directly instead. Maybe this colud be also remain unchanged...... Please apply if you think it is ok to do so. The diff applies on today's cvs tarball (2004-08-25). Thanks in advance, Ciao, Tito git-svn-id: svn://busybox.net/trunk/busybox@9165 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Felipe Kellermann writes:andersen2004-08-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unfortunatelly I've not followed the last two or three weeks commits (new semester started and so now I rarely have time to fix my personal bridge) but tonight I synched my tree and immediately noticed a rather nasty bug! [Using libbb/interface.c:1.24] # grep eth0 /proc/net/dev | xargs eth0:311708397 237346 1670 0 1789 1670 0 0 22580308 120297 0 0 0 102 0 0 # ifconfig eth0 eth0 Link encap:Ethernet HWaddr 00:20:AF:7C:EA:B7 inet addr:10.0.0.1 Bcast:10.0.0.127 Mask:255.255.255.128 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) Interrupt:5 Base address:0x320 All values `ifconfig' is showing are `zeroed' -- I quickly looked at the last commits I missed and noticed that there were a commit relating to ifconfig, libbb/interface.c:1.23->1.24 (PatchSet 4338). I've reversed the patch and now everything is working again. I compared the get_name's return values from the 1.23 and 1.24 and quickly noticed that the new revision is leaving `p' right on the sep while the rev 1.23 was leaving it right on the starting of the values... 1-line, 1/3-minute patch attached :-) git-svn-id: svn://busybox.net/trunk/busybox@9162 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Manousaridis Angelos to cleanup stale file descriptors, it was ↵bug12004-08-252-3/+6
| | | | | | preventing unmounting an initial filesystem. git-svn-id: svn://busybox.net/trunk/busybox@9147 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Rodney Radford adding x86_64 support.andersen2004-08-191-3/+13
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9132 69ca8d6d-28ef-0310-b511-8ec308f3f277
* regularly update the status line displayandersen2004-08-191-4/+4
| | | | | | | -Erik git-svn-id: svn://busybox.net/trunk/busybox@9131 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Mike Castle to cleanup some modutils issues, inandersen2004-08-191-59/+33
| | | | | | | particular making alias support work better. git-svn-id: svn://busybox.net/trunk/busybox@9130 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Tito adding support for '-q'andersen2004-08-191-1/+4
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9129 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Tito documenting the '-q' optionandersen2004-08-191-2/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9128 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Vladimir N. Oleynik:andersen2004-08-192-1/+2
| | | | | | | | | | | | | | | | | | | On Wed Aug 18, 2004 at 06:52:57PM +0800, Matt Johnston wrote: > I've come across some strange-seeming behaviour when running programs > under Busybox (1.0.0-rc3) ash. If the child process sets stdin to be > non-blocking and then exits, the parent ash will also exit. A quick strace > shows that a subsequent read() from stdin returns EAGAIN (as would be > expected): Thanks! Patch attached. --w vodz git-svn-id: svn://busybox.net/trunk/busybox@9127 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fixup 'dc' usageandersen2004-08-181-5/+5
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9118 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Prepare for releaseandersen2004-08-164-206/+450
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9105 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Bump versionandersen2004-08-161-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9104 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Only pass modprobe module params with 2.6.x kernel support.andersen2004-08-161-2/+4
| | | | | | | -Erik git-svn-id: svn://busybox.net/trunk/busybox@9103 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Do not use vfork, as init is not vfork safe. Do not allowandersen2004-08-161-4/+2
| | | | | | | askfirst when mmuless. git-svn-id: svn://busybox.net/trunk/busybox@9102 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Bertrand Baudet writes:andersen2004-08-161-2/+2
| | | | | | | | | | | | | | | Looks like the -D and -H options of the adduser applet aren't handle properly in BusyBox. This patch fixes the masks definition for those options according to there position in the optstring. Patch against RC2 but should also apply cleanly against CVS. Bertrand git-svn-id: svn://busybox.net/trunk/busybox@9101 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Joe.C writes:andersen2004-08-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bug is in busybox 1.0.0-rc2. When using lash exec builtin with redirection, the opened file fd keep increasing. For example, please try the following command with lash. ls -al /proc/<lash pid>/fd exec /bin/sh 2>/dev/null ls -al /proc/<lash pid>/fd The last 'ls' command output will look like this. The fd number 4 shouldn't exist. lrwx------ 1 501 100 64 Aug 13 13:56 4 -> /dev/pts/5 l-wx------ 1 501 100 64 Aug 13 13:56 2 -> /dev/null lrwx------ 1 501 100 64 Aug 13 13:56 1 -> /dev/pts/5 lrwx------ 1 501 100 64 Aug 13 13:56 0 -> /dev/pts/5 dr-xr-xr-x 3 501 100 0 Aug 13 13:56 .. dr-x------ 2 501 100 0 Aug 13 13:56 . This one-line patch fix this problem by setting CLOEXEC flag for squirrel fd. Please apply. Joe.C git-svn-id: svn://busybox.net/trunk/busybox@9100 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Use __kernel_old_dev_t for 2.6.x kernelsandersen2004-08-161-0/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9099 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Aurelien Jacobs writes:andersen2004-08-161-3/+1
| | | | | | | | | | | | | | | | | | | | | with a quick conversion you will see that 132608 == 0x20600 so noticed that the elif will never be matched ! Apparently there was already a try to modify this in CVS which was reverted (it was plain wrong). I don't know when __kernel_old_dev_t is needed, but with a 2.6.7 or a 2.6.8 this is __kernel_dev_t wich is needed. I corrected this with the following patch but maybe older 2.6 still need __kernel_old_dev_t ? I think this should be corrected before 1.0. Thanks Aurel git-svn-id: svn://busybox.net/trunk/busybox@9098 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Christian Ostheimer writes:andersen2004-08-141-1/+1
| | | | | | | | | | | | | | Hello, function build_dep in modprobe.c assumes that dependencies of one module have not more than 255 chars; that is not sufficient in kernel 2.6.7 (alsa sound modules). - Below is a diff that solves the problem for me. With regards, Christian Ostheimer git-svn-id: svn://busybox.net/trunk/busybox@9093 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from solar to fix problems with get_name()andersen2004-08-121-23/+28
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9088 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Set default command to list rather than get, its default behaviour nowbug12004-08-111-2/+1
| | | | | | | coincides with upstream. Patch from debian diff. git-svn-id: svn://busybox.net/trunk/busybox@9087 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Mike Castle, dont print an empty line (patch modified by me tobug12004-08-111-9/+13
| | | | | | | change formatting). git-svn-id: svn://busybox.net/trunk/busybox@9086 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Tito to fix memory leak upon error.bug12004-08-111-2/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9085 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Bastian Blank to add 64 bit support to the test command.bug12004-08-112-14/+35
| | | | | | | Example of broken usage: ./busybox test 2147483648 -gt 2147483648 git-svn-id: svn://busybox.net/trunk/busybox@9084 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Phil Blundellto improve substring matchbug12004-08-111-1/+4
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9083 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Willian Barsse wrotebug12004-08-111-8/+7
| | | | | | | | | | | | | | | | | | | | "There seems to be a slight problem with the "mod_strcmp" function in modprobe.c, it scans for the first occurence of the module name in the "mod_path" variable and expects it to be the last path element. ie /lib/modules/2.4.22-debug/kernel/fs/vfat in my example. The comparison will always fail if mod_path contains another substring matching the module name." Robert McQueen wrote "Although William Barsse's patch fixed mod_strcmp for 2.4 kernels, there was a remaining problem which prevented it from working for me. I've just tracked it down - when you enable kernel 2.6 module support it hard-wired the extension to .ko instead of checking at runtime like the other places where 2.4 differs from 2.6. The attached patch fixes this for me." git-svn-id: svn://busybox.net/trunk/busybox@9082 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Tito to fix warnings about redifined functionions barrier and likely.bug12004-08-061-9/+9
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9064 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Part of patch from William Barsse, fixes a problem with unescaped %.bug12004-08-061-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9063 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Michael Leibow, MichaelLe at belkin.com writes:andersen2004-08-041-375/+1056
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A question was posted a month ago by Mark Alamo to see if others had problems with sourcing subscripts within msh. We asked his firm to fix the msh.c bug he described because we didn't have enough time to do it ourselves. When msh.c is executing a compound statement and there is a . command to source another script file, msh.c will not execute the subscript until it's completed executing the rest of the compound statement. His example was this: Echo "Start" ; . ./subA; echo "mid" ; . ./subB ; echo "end" subA and subB execute AFTER end is printed in reverse order. The same is true if the sourced files are inside an if else fi, case esac, or any compound statement. Attached is a patch to msh.c. It fixes the problem. Cd to the root of your busybox tree and execute "patch -p1 < msh.c.patch" Unfortunately, I won't have more time to work on this so I hope that there aren't any problems! Michael Leibow Senior Software Engineer Belkin Corporation git-svn-id: svn://busybox.net/trunk/busybox@9062 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Run msh through indentandersen2004-08-041-1313/+1164
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9061 69ca8d6d-28ef-0310-b511-8ec308f3f277
* William Barsse writes:andersen2004-08-031-10/+9
| | | | | | | | | | | | | | | | fixes two other issues (plus the previous as well) with a 2.4 kernel : - should be able to modprobe an already loaded module and get 0 return code : # modprobe <something> && modprobe <something> && echo "ok" || echo "failed" .... failed Well, hope this helps and that I didn't screw up again, - William git-svn-id: svn://busybox.net/trunk/busybox@9057 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito, farmatito at tiscali dot it writes:andersen2004-08-035-6/+10
| | | | | | | | | | | | | | Hi to all, This patch is useful for: 1) remove an unused var from extern char *find_real_root_device_name(const char* name) changing it to extern char *find_real_root_device_name(void). 2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and util-linux/umount.c accordingly. 3) fixes a bug, really a false positive, in find_real_root_device_name() that happens if in the /dev directory exists a link named root (/dev/root) that should be skipped but is not. This affects applets like df that display wrong results git-svn-id: svn://busybox.net/trunk/busybox@9056 69ca8d6d-28ef-0310-b511-8ec308f3f277
* fixup cut-n-paste problemandersen2004-08-011-14/+0
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9055 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Simon Poole reports that awk segfaults when environment variablesandersen2004-07-301-0/+4
| | | | | | | | | | | | | | with no value exist, i.e. $ export BOB='' % ./busybox awk Segmentation fault This patch teaches awk to not blow chunks on empty env variables. -Erik git-svn-id: svn://busybox.net/trunk/busybox@9054 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix incorrect arguments being passed to mknodandersen2004-07-301-2/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9049 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Umm. Not guilty by reason of insanity.andersen2004-07-302-3/+3
| | | | | | | -Erik git-svn-id: svn://busybox.net/trunk/busybox@9048 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fixup getty, login, etc so the utmp and wtmp are updated, allowingandersen2004-07-305-5/+23
| | | | | | | | the 'who' and 'last' applets among other things to work as expected. -Erik git-svn-id: svn://busybox.net/trunk/busybox@9047 69ca8d6d-28ef-0310-b511-8ec308f3f277
* use SIGTERM to kill off udhcpd, not SIGKILLandersen2004-07-301-1/+4
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9046 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix up brain damage with the way major and minor are used toandersen2004-07-301-1/+1
| | | | | | | create a dev_t git-svn-id: svn://busybox.net/trunk/busybox@9045 69ca8d6d-28ef-0310-b511-8ec308f3f277
* As noted by Eric Spakman, calling static_down() and then callingandersen2004-07-301-14/+4
| | | | | | | | bootp_down() seems redundant, esp since bootp_down was a subset of static_down, so just use that... git-svn-id: svn://busybox.net/trunk/busybox@9044 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Clean up hex escape support.mjn32004-07-291-21/+43
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9038 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Thanks to Ken Roberts, fix the slackware urlandersen2004-07-281-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9036 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Felipe Kellermann noticed a missing `break'.andersen2004-07-271-0/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9030 69ca8d6d-28ef-0310-b511-8ec308f3f277
* document stuff I have donesandman2004-07-261-0/+4
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9029 69ca8d6d-28ef-0310-b511-8ec308f3f277
* add missing ;andersen2004-07-261-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9026 69ca8d6d-28ef-0310-b511-8ec308f3f277
* bump version to -rc2andersen2004-07-261-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9025 69ca8d6d-28ef-0310-b511-8ec308f3f277
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-04-14 23:25:47 +0000