aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Junio Hamano, junio at twinsun dot com writes:andersen2004-03-311-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sed command in busybox 1.0.0-pre8 loses leading whitespace in 'a' command ('i' and 'c' commands are also affected). A patch to fix this is attached at the end of this message. The following is a transcript that reproduces the problem. The first run uses busybox 1.0.0-pre3 as "/bin/sed" command, which gets the expected result. Later in the test, /bin/sed symlink is changed to point at busybox 1.0.0-pre8 and the test script is run again, which shows the failure. === reproduction recipe === * Part 1. Use busybox 1.0.0-pre3 as sed; this works. root# cd /tmp root# cat 1.sh #!/bin/sh cd /tmp rm -f ipsec.conf ipsec.conf+ cat >ipsec.conf <<\EOF version 2.0 config setup klipsdebug=none plutodebug=none plutostderrlog=/dev/null conn %default keyingtries=1 ... EOF sed -e '/^config setup/a\ nat_traversal=yes' ipsec.conf >ipsec.conf+ mv -f ipsec.conf+ ipsec.conf root# sh -x 1.sh + cd /tmp + rm -f ipsec.conf ipsec.conf+ + cat + sed -e /^config setup/a\ nat_traversal=yes ipsec.conf + mv -f ipsec.conf+ ipsec.conf root# cat ipsec.conf version 2.0 config setup nat_traversal=yes klipsdebug=none plutodebug=none plutostderrlog=/dev/null conn %default keyingtries=1 ... root# sed --version sed: invalid option -- - BusyBox v1.00-pre3 (2004.02.26-18:47+0000) multi-call binary Usage: sed [-nef] pattern [files...] * Part 2. Continuing from the above, use busybox 1.0.0-pre8 as sed; this fails. root# ln -s busybox-pre8 /bin/sed-8 root# mv /bin/sed-8 /bin/sed root# sed --version This is not GNU sed version 4.0 root# sed -- BusyBox v1.00-pre8 (2004.03.30-02:44+0000) multi-call binary Usage: sed [-nef] pattern [files...] root# sh -x 1.sh + cd /tmp + rm -f ipsec.conf ipsec.conf+ + cat + sed -e /^config setup/a\ nat_traversal=yes ipsec.conf + mv -f ipsec.conf+ ipsec.conf root# cat ipsec.conf version 2.0 config setup nat_traversal=yes klipsdebug=none plutodebug=none plutostderrlog=/dev/null conn %default keyingtries=1 ... root# === reproduction recipe ends here === This problem was introduced in 1.0.0-pre4. The problem is that the command argument parsing code strips leading whitespaces too aggressively. When running the above example, the piece of code in question gets "\n\tnat_traversal=yes" as its argument in cmdstr variable (shown part in the following patch). What it needs to do at this point is to strip the first newline and nothing else, but it instead strips all the leading whitespaces at the beginning of the string, thus losing the tab character. The following patch fixes this. git-svn-id: svn://busybox.net/trunk/busybox@8676 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Thomas Winkler:andersen2004-03-311-3/+9
| | | | | | | | | | ifconfig did not look up hostnames, so ifconfig lo localhost would not work, you have to do ifconfig lo 127.0.0.1 git-svn-id: svn://busybox.net/trunk/busybox@8675 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Thomas Winkler showing the the system time for each processandersen2004-03-311-0/+51
| | | | | | | when running 'top' git-svn-id: svn://busybox.net/trunk/busybox@8674 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Thomas Winkler -- vi -R did not workandersen2004-03-311-1/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8673 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Sigh. what a mess.andersen2004-03-301-2/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8672 69ca8d6d-28ef-0310-b511-8ec308f3f277
* As waldi noticed, checks for the size of an off_t and castingandersen2004-03-301-13/+6
| | | | | | | etc was also redundant and possibly buggy... git-svn-id: svn://busybox.net/trunk/busybox@8671 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Go ahead and kill off the FDISK_SUPPORT_LARGE_DISKS option,andersen2004-03-301-8/+0
| | | | | | | as it is redundant.... git-svn-id: svn://busybox.net/trunk/busybox@8670 69ca8d6d-28ef-0310-b511-8ec308f3f277
* The fdisk llseek junk was redundant, since both uClibc and glibcandersen2004-03-302-74/+8
| | | | | | | | automatically promote lseek and friends to their 64 bit counterparts when CONFIG_LFS is enabled, since it enables __USE_FILE_OFFSET64 git-svn-id: svn://busybox.net/trunk/busybox@8669 69ca8d6d-28ef-0310-b511-8ec308f3f277
* As noted by Martin Schwenke, the example for find was wrongandersen2004-03-291-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8667 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Yet more doc cleanupsandersen2004-03-272-12/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8666 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Add missing include filesandersen2004-03-273-0/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8665 69ca8d6d-28ef-0310-b511-8ec308f3f277
* passwd and sulogin also need libcrypt, via libbb/pw_encrypt()andersen2004-03-271-3/+6
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8664 69ca8d6d-28ef-0310-b511-8ec308f3f277
* s/fileno\(stdin\)/STDIN_FILENO/gandersen2004-03-2721-35/+35
| | | | | | | s/fileno\(stdout\)/STDOUT_FILENO/g git-svn-id: svn://busybox.net/trunk/busybox@8663 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Vladimir N. Oleynik (vodz) writes:andersen2004-03-271-22/+21
| | | | | | | | | | | | | | | | | | Ok. Last patch reduce 73 bytes for compensate (and over) your changes ;-) Comments: Added cin_fileno variable, auto setted to 0 from BSS and have "eq" stdin descriptor if isatty(stout)==0, removed global variable FILE* cin. Removed default setting to terminal_width/terminal_height, this used only from main() and setted after call get_terminal_width_height() always correct. Variable please_display_more_prompt changed to bits logic, have size reducing. --w vodz git-svn-id: svn://busybox.net/trunk/busybox@8662 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Update docsandersen2004-03-274-114/+89
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8661 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Brian Pomerantz writes:andersen2004-03-233-3/+5
| | | | | | | | | | | | | | | | | | | I've noticed a bug in the "autowidth" feature more, and is probably in others. The call to the function get_terminal_width_height() passes in a file descriptor but that file descriptor is never used, instead the ioctl() is called with 0. In more_main() the call to get_terminal_width_height() passes 0 as the file descriptor instead of fileno(cin). This isn't a problem when you more a file (e.g. "more /etc/passwd") but when you pipe a file to it (e.g. "cat /etc/passwd | more") the size of the terminal cannot be determined because file descriptor 0 is not a terminal. The fix is simple, I've attached a patch for more.c and get_terminal_width_height.c. BAPper git-svn-id: svn://busybox.net/trunk/busybox@8656 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Some corrections from vodz:sandman2004-03-221-11/+6
| | | | | | | | - Make -u/-l mutually exclusive - Minor size reduction git-svn-id: svn://busybox.net/trunk/busybox@8655 69ca8d6d-28ef-0310-b511-8ec308f3f277
* The utc variable was not modified according to the -u/-l command linesandman2004-03-211-2/+8
| | | | | | | parameters. git-svn-id: svn://busybox.net/trunk/busybox@8654 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito noticed a printf that should have been a bb_error_msg.andersen2004-03-201-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8652 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Oops.. got a bit to aggressive with size optimization and global replace. :-(mjn32004-03-191-3/+5
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8651 69ca8d6d-28ef-0310-b511-8ec308f3f277
* As noted in a patch from Kendrick Hamilton, rmmod was onlyandersen2004-03-191-4/+1
| | | | | | | | half way converted, and still used the old delete_module(), call rather than a syscall, in one spot. git-svn-id: svn://busybox.net/trunk/busybox@8650 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Add missing ELFCLASSM for m68kandersen2004-03-191-2/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8647 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Only use R_68K_GOTOFF if it is definedandersen2004-03-191-2/+6
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8646 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix broken arg parsing (was not passing pointer to items so p, argc, and argvandersen2004-03-191-132/+117
| | | | | | | | were only modified locally). Fix error reporting to properly describe why ioctls fail. git-svn-id: svn://busybox.net/trunk/busybox@8644 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from vodz to fix the dynamic vars patch, which I should notandersen2004-03-162-75/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | have checked in. Vladimir writes: Your patch have many problem. 1. You always added + time(). This cannot reset RANDOM=value for debuging with replay sequential. 2. Hmm. I examine bash 2.04 source. This pseudorandom generator use low bits of counter value. You use high bits. This make bad pseudorandom values after have 0-value. For example, if + time() do remove, your generator always return 0 after first generate 0. 3. Memory leak per call. Use ash-unlike unecessary bb_strdup function. 4. Unsupport show last $RANDOM value for "set" and "export" command. 5. Bloat code. Busybox-unlike patch - added unstandart feature as default hardcode. Last patch attached. Erik, why you apply Paul patch with have 5-th point problem? :( Last patch have ash change xwrite() to fresh libbb/bb_full_write interfase (haved loop after EINTR). --w vodz git-svn-id: svn://busybox.net/trunk/busybox@8632 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Oops. Using the wrong variable was a rather stupidandersen2004-03-151-1/+1
| | | | | | | thing for me to do. git-svn-id: svn://busybox.net/trunk/busybox@8631 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Remove trailing whitespace. Update copyright to include 2004.andersen2004-03-15374-2051/+2048
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8630 69ca8d6d-28ef-0310-b511-8ec308f3f277
* I redid route.mjn32004-03-131-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8628 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Update docs for start_stop_daemon to match reality. Updateandersen2004-03-133-55/+81
| | | | | | | the reality a bit to better match debian behavior. git-svn-id: svn://busybox.net/trunk/busybox@8627 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix some doc generation problemsandersen2004-03-132-21/+24
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8626 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Hideki IWAMOTO writes:andersen2004-03-121-2/+2
| | | | | | | | | | | | | | | | | Current `tr' implementation has a problem, if `plain char' is signed. [current cvs version] >echo a | _install/usr/bin/tr '\0' '\377' Segmentation fault (core dumped) [patched version] >echo a | _install/usr/bin/tr '\0' '\377' a git-svn-id: svn://busybox.net/trunk/busybox@8624 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix some goofy formattingandersen2004-03-121-4/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8623 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Add prototypes for safe_strtol and friendsandersen2004-03-121-1/+5
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8622 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix awk entry, which was not showing up in BusyBox.txt for some reasonandersen2004-03-121-6/+12
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8621 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Paul Mundt, lethal at linux-sh dot org writes:andersen2004-03-111-14/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here's a follow-up replacement to the patch I sent earlier, this adjusts some of the semantics of the dynamic variable setting. Namely, dynamic vars can hook a set handler (which RANDOM uses to adjust the seed). They'll only lose their dynamic status if they're unset. I've used the same approach that bash does to come up with the random number, mostly just for consistency. For example: $ echo $RANDOM 13759 $ echo $RANDOM 20057 $ echo $RANDOM 1502 $ export RANDOM=42 $ echo $RANDOM 24179 $ echo $RANDOM 2046 $ unset RANDOM $ echo $RANDOM $ export RANDOM=42 $ echo $RANDOM 42 $ git-svn-id: svn://busybox.net/trunk/busybox@8615 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Thomas Frohlich to fix an option ordering bug of mine.bug12004-03-101-3/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8611 69ca8d6d-28ef-0310-b511-8ec308f3f277
* When displaying the size in 1kB blocks round up if an odd number ofbug12004-03-101-1/+5
| | | | | | | blocks git-svn-id: svn://busybox.net/trunk/busybox@8610 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch by Seth W. Klein, the -l switch was reversedbug12004-03-101-2/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8609 69ca8d6d-28ef-0310-b511-8ec308f3f277
* In spite of the feature freeze, check in a complete rework of route whichmjn32004-03-104-485/+501
| | | | | | | | | | | fixes some bugs, adds some error checking, and removes _lots_ of bloat. Text size on i386... old new ipv6 5425 3523 no ipv6 3143 2193 git-svn-id: svn://busybox.net/trunk/busybox@8607 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Note that /proc must be mounted for filesystem type autodetectionandersen2004-03-091-1/+2
| | | | | | | | to work. Without /proc mounted, one must explicitly specify the type of every filesystem being mounted. git-svn-id: svn://busybox.net/trunk/busybox@8604 69ca8d6d-28ef-0310-b511-8ec308f3f277
* David Anders (prpplague) submitted this patch to allow login to workandersen2004-03-091-2/+2
| | | | | | | when the device nodes are symlinks on a read only file system. git-svn-id: svn://busybox.net/trunk/busybox@8603 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix broken sort order flags.mjn32004-03-081-3/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8601 69ca8d6d-28ef-0310-b511-8ec308f3f277
* My bug. :-(mjn32004-03-081-0/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8600 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix/eliminate use of atolandersen2004-03-069-54/+132
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8598 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Matt Kraai to fix debian bug number 231994.bug12004-03-061-4/+7
| | | | | | | There was an extra blank line preceding the first directory. git-svn-id: svn://busybox.net/trunk/busybox@8595 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Woops, how did that get in therebug12004-03-061-5/+0
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8594 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Don't build these support functions for uClibc, as it always suppliesmjn32004-03-061-0/+4
| | | | | | | versions. git-svn-id: svn://busybox.net/trunk/busybox@8593 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from John Powers, adds multicast (rfc2090) and timeout (rfc2349)bug12004-03-051-0/+1053
| | | | | | | options git-svn-id: svn://busybox.net/trunk/busybox@8582 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from duane no-name, optionally request additional itemsbug12004-03-051-0/+126
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8581 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch by Andrew Victor,bug12004-03-052-5/+10
| | | | | | | | | | | | | | In arpping.h, fix structure alignment of "struct arpMsg". GCC can insert padding in the structure which causes udhcpd to send an invalid ARP packet on the network. It will then not receive a valid reply, which can cause it to assign an IP address that's already in use on the network. (With kernels before 2.4.20, the "struct ethhdr" in linux/if_ether.h wasn't marked as packed. This is also an issue if your toolchain was built with a pre-2.4.20 kernel). git-svn-id: svn://busybox.net/trunk/busybox@8580 69ca8d6d-28ef-0310-b511-8ec308f3f277
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-08-09 13:36:29 +0000