aboutsummaryrefslogtreecommitdiff
path: root/coreutils (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Tito writes:andersen2004-09-022-67/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hi Erik, Hi to all, This is part five of the my_get*id story. I've tweaked a bit this two functions to make them more flexible, but this changes will not affect existing code. Now they work so: 1) my_getpwuid( char *user, uid_t uid, int bufsize) if bufsize is > 0 char *user cannot be set to NULL on success username is written on static allocated buffer on failure uid as string is written to buffer and NULL is returned if bufsize is = 0 char *user can be set to NULL on success username is returned on failure NULL is returned if bufsize is < 0 char *user can be set to NULL on success username is returned on failure an error message is printed and the program exits 2) 1) my_getgrgid( char *group, uid_t uid, int bufsize) if bufsize is > 0 char *group cannot be set to NULL on success groupname is written on static allocated buffer on failure gid as string is written to buffer and NULL is returned if bufsize is = 0 char *group can be set to NULL on success groupname is returned on failure NULL is returned if bufsize is < 0 char *group can be set to nULL on success groupname is returned on failure an error message is printed and the program exits This changes were needed mainly for my new id applet. It is somewhat bigger then the previous but matches the behaviour of GNU id and is capable to handle usernames of whatever length. BTW: at a first look it seems to me that it will integrate well (with just a few changes) with the pending patch in patches/id_groups_alias.patch. The increase in size is balanced by the removal of my_getpwnamegid.c from libbb as this was used only in previous id applet and by size optimizations made possible in whoami.c and in passwd.c. I know that we are in feature freeze but I think that i've tested it enough (at least I hope so.......). git-svn-id: svn://busybox.net/trunk/busybox@9194 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fixup some warningsandersen2004-08-281-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@9180 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito writes:andersen2004-08-261-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | Hi, I've fixed also the issue of whoami cutting down usernames. This time I cannot send a diff because i don't know if my previous patches will be applied or not, so I send in the whole file. The changes I've made don't affect size but ensure that usernames of whatever lenght are correctly displayed. root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami_orig.o text data bss dec hex filename 102 0 0 102 66 whoami_orig.o root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami.o text data bss dec hex filename 93 0 0 93 5d whoami.o This should be applied even if the other patches aren't as this matches the behaviour of the GNU whoami. Thanks in advance, Ciao, Tito git-svn-id: svn://busybox.net/trunk/busybox@9168 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito writes:andersen2004-08-263-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hi, I've spent the half night staring at the devilish my_getpwuid and my_getgrgid functions trying to find out a way to avoid actual and future potential buffer overflow problems without breaking existing code. Finally I've found a not intrusive way to do this that surely doesn't break existing code and fixes a couple of problems too. The attached patch: 1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows 2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h. 3) The behaviour of tar, ls and logger is unchanged. 4) The behavior of ps with somewhat longer usernames messing up output is fixed. 5) The only bigger change was the increasing of size of the buffers in id.c to avoid false negatives (unknown user: xxxxxx) with usernames longer than 8 chars. The value i used ( 32 chars ) was taken from the tar header ( see gname and uname). Maybe this buffers can be reduced a bit ( to 16 or whatever ), this is up to you. 6) The increase of size of the binary is not so dramatic: size busybox text data bss dec hex filename 239568 2300 36816 278684 4409c busybox size busybox_fixed text data bss dec hex filename 239616 2300 36816 278732 440cc busybox 7) The behaviour of whoami changed: actually it prints out an username cut down to the size of the buffer. This could be fixed by increasing the size of the buffer as in id.c or avoid the use of my_getpwuid and use getpwuid directly instead. Maybe this colud be also remain unchanged...... Please apply if you think it is ok to do so. The diff applies on today's cvs tarball (2004-08-25). Thanks in advance, Ciao, Tito git-svn-id: svn://busybox.net/trunk/busybox@9165 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Bastian Blank to add 64 bit support to the test command.bug12004-08-112-14/+35
| | | | | | | Example of broken usage: ./busybox test 2147483648 -gt 2147483648 git-svn-id: svn://busybox.net/trunk/busybox@9084 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Tito, farmatito at tiscali dot it writes:andersen2004-08-031-1/+1
| | | | | | | | | | | | | | Hi to all, This patch is useful for: 1) remove an unused var from extern char *find_real_root_device_name(const char* name) changing it to extern char *find_real_root_device_name(void). 2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and util-linux/umount.c accordingly. 3) fixes a bug, really a false positive, in find_real_root_device_name() that happens if in the /dev directory exists a link named root (/dev/root) that should be skipped but is not. This affects applets like df that display wrong results git-svn-id: svn://busybox.net/trunk/busybox@9056 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fixup getty, login, etc so the utmp and wtmp are updated, allowingandersen2004-07-301-0/+1
| | | | | | | | the 'who' and 'last' applets among other things to work as expected. -Erik git-svn-id: svn://busybox.net/trunk/busybox@9047 69ca8d6d-28ef-0310-b511-8ec308f3f277
* BusyBox has no business hard coding the number of major and minor bits for aandersen2004-07-261-7/+3
| | | | | | | | | | | | dev_t. This is especially important now that the user space concept of a dev_t and the kernel concept of a dev_t are divergant. The only bit of user space allowed to know the number of major and minor bits is include/sys/sysmacros.h (i.e. part of libc). When used with a current C library and a 2.6.x kernel, this fix should allow BusyBox to support wide device major/minor numbers. -Erik git-svn-id: svn://busybox.net/trunk/busybox@9015 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Felipe Kellermann, fix endless loop when first > last andbug12004-07-231-6/+13
| | | | | | | increment > 0. git-svn-id: svn://busybox.net/trunk/busybox@9010 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Felipe Kellermann writes,bug12004-07-231-5/+5
| | | | | | | | | | | "As noticed today by Steven Scholz, the od's `-v' was broken. I've fixed that and now both the flags `-v' and `-a' are OK" Fixes a segfault in echo "uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu\02bar\4"| ./busybox od -av git-svn-id: svn://busybox.net/trunk/busybox@9004 69ca8d6d-28ef-0310-b511-8ec308f3f277
* If read were to return with an error, bad things would happen. Fix it.mjn32004-05-261-2/+6
| | | | | | | Also, make sure read errors are reflected in the applet exit code. git-svn-id: svn://busybox.net/trunk/busybox@8879 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Use STDIN_FILENO rather than '0'andersen2004-05-261-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8871 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Rob Landley writes:andersen2004-05-261-1/+1
| | | | | | | | | | | Run this test, against both busybox and a non-busybox version of "tee". while true; do i=$[$i+1]; echo "hello $i"; sleep 1; done | ./busybox tee Now run the busybox one again with the following small patch applied: git-svn-id: svn://busybox.net/trunk/busybox@8869 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Steve Grubb writes:andersen2004-05-051-1/+3
| | | | | | | | | | | | | | Hi, I just re-reviewed the patch I just sent...and it needed to be BUFSIZ-3 in dos2unix.c . tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. The loop increments by 2. That's why it should be BUFSIZ-3. Best Regards, Steve Grubb git-svn-id: svn://busybox.net/trunk/busybox@8805 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Steve Grubb writes:andersen2004-05-051-1/+1
| | | | | | | | | | | | | | Hello, I found and patched 2 more bugs. The first is a misplaced semi-colon. The second one is a buffer overflow. I doubt the buffer overflow is triggered in real life. But you never know what those wily hackers are up to. Thanks, Steve Grubb git-svn-id: svn://busybox.net/trunk/busybox@8804 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Update my email address, document some of my tasks in the AUTHORS filebug12004-04-253-3/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8782 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Thats odd. I guess this was cut-n-paste error, but vodzandersen2004-04-161-1/+1
| | | | | | | email address was wrong! git-svn-id: svn://busybox.net/trunk/busybox@8765 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Larry Doolittle writes:andersen2004-04-1410-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | This is a bulk spelling fix patch against busybox-1.00-pre10. If anyone gets a corrupted copy (and cares), let me know and I will make alternate arrangements. Erik - please apply. Authors - please check that I didn't corrupt any meaning. Package importers - see if any of these changes should be passed to the upstream authors. I glossed over lots of sloppy capitalizations, missing apostrophes, mixed American/British spellings, and German-style compound words. What is "pretect redefined for test" in cmdedit.c? Good luck on the 1.00 release! - Larry git-svn-id: svn://busybox.net/trunk/busybox@8759 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix non standard 'date -R' formattingandersen2004-04-061-4/+4
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8691 69ca8d6d-28ef-0310-b511-8ec308f3f277
* s/fileno\(stdin\)/STDIN_FILENO/gandersen2004-03-272-5/+5
| | | | | | | s/fileno\(stdout\)/STDOUT_FILENO/g git-svn-id: svn://busybox.net/trunk/busybox@8663 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Brian Pomerantz writes:andersen2004-03-231-1/+1
| | | | | | | | | | | | | | | | | | | I've noticed a bug in the "autowidth" feature more, and is probably in others. The call to the function get_terminal_width_height() passes in a file descriptor but that file descriptor is never used, instead the ioctl() is called with 0. In more_main() the call to get_terminal_width_height() passes 0 as the file descriptor instead of fileno(cin). This isn't a problem when you more a file (e.g. "more /etc/passwd") but when you pipe a file to it (e.g. "cat /etc/passwd | more") the size of the terminal cannot be determined because file descriptor 0 is not a terminal. The fix is simple, I've attached a patch for more.c and get_terminal_width_height.c. BAPper git-svn-id: svn://busybox.net/trunk/busybox@8656 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Remove trailing whitespace. Update copyright to include 2004.andersen2004-03-1538-114/+114
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8630 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Hideki IWAMOTO writes:andersen2004-03-121-2/+2
| | | | | | | | | | | | | | | | | Current `tr' implementation has a problem, if `plain char' is signed. [current cvs version] >echo a | _install/usr/bin/tr '\0' '\377' Segmentation fault (core dumped) [patched version] >echo a | _install/usr/bin/tr '\0' '\377' a git-svn-id: svn://busybox.net/trunk/busybox@8624 69ca8d6d-28ef-0310-b511-8ec308f3f277
* When displaying the size in 1kB blocks round up if an odd number ofbug12004-03-101-1/+5
| | | | | | | blocks git-svn-id: svn://busybox.net/trunk/busybox@8610 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch by Seth W. Klein, the -l switch was reversedbug12004-03-101-2/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8609 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix broken sort order flags.mjn32004-03-081-3/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8601 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix/eliminate use of atolandersen2004-03-061-27/+3
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8598 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Matt Kraai to fix debian bug number 231994.bug12004-03-061-4/+7
| | | | | | | There was an extra blank line preceding the first directory. git-svn-id: svn://busybox.net/trunk/busybox@8595 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Close bracket in description from Peter Willis's eject appletbug12004-03-051-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8572 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Return 1 upon failurebug12004-02-221-1/+2
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8533 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Use return instead of exit, use == instead of & ==, left justify labels,bug12004-02-211-33/+29
| | | | | | | adjustment of whitespace. git-svn-id: svn://busybox.net/trunk/busybox@8530 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Add the -r option, patch from Rob with some help from myself.bug12004-02-171-4/+11
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8501 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Woops, im getting ahead of myself, we dont have the -r (refernece)bug12004-02-171-2/+4
| | | | | | | option yet git-svn-id: svn://busybox.net/trunk/busybox@8493 69ca8d6d-28ef-0310-b511-8ec308f3f277
* define option names to be clearer, simplify nested if statements, removebug12004-02-171-30/+29
| | | | | | | un-needed if statement, minor indenting change git-svn-id: svn://busybox.net/trunk/busybox@8492 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Vladimir N. Oleynik writes:andersen2004-02-051-2/+2
| | | | | | | | | | | | | | Hi, Glenn. Current CVS "ls" applet have small problem: some options ignoring. Last patch attached ;-) --w vodz git-svn-id: svn://busybox.net/trunk/busybox@8411 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Jean Wolter writes:andersen2004-02-041-1/+1
| | | | | | | | | | | | | | | | | | Hello, when calling seq with seq 1 1 it generates an "endless" list of numbers until the counter wraps and reaches 1 again. The follwoing small patch should introduce the expected behavior (output of 1 and termination): regards, Jean git-svn-id: svn://busybox.net/trunk/busybox@8399 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Use bb_xstrdup() instead of strdup().mjn32004-02-011-1/+1
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8388 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Avoid symbol naming conflict with libmandersen2004-01-301-4/+4
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8372 69ca8d6d-28ef-0310-b511-8ec308f3f277
* New applet, seq. No options, just the basics.bug12004-01-273-0/+51
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8354 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Align using spaces to furthurest character and then one tab, now theybug12004-01-271-60/+59
| | | | | | | should always be aligned. git-svn-id: svn://busybox.net/trunk/busybox@8351 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Pascal Brisset writes:andersen2004-01-261-1/+1
| | | | | | | | | | | | | uuencode fails to encode binary data because it right-shifts bytes as signed chars and keeps the duplicated sign bits. The original base64_encode() from wget/http.c is broken as well, but it is only used to encode ascii data. -- Pascal git-svn-id: svn://busybox.net/trunk/busybox@8348 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Be stricter when converting strings to integers. Should fix the problemmjn32004-01-251-9/+11
| | | | | | | reported by Rob. git-svn-id: svn://busybox.net/trunk/busybox@8347 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Add the -r option as a synonym of -Rbug12004-01-251-1/+8
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8345 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Enable long options, adds 150 bytes.bug12004-01-231-1/+12
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8339 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Check valid options were givenbug12004-01-231-0/+6
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8337 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Dont change ownership unless we created the directory.bug12004-01-231-4/+6
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8336 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Remove unneeded conditions and logic, fix bug where ownership didntbug12004-01-231-33/+34
| | | | | | | | | change. Dont use bb_make_directory it doesnt have the features, and its ugly to work around it. git-svn-id: svn://busybox.net/trunk/busybox@8335 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Fix a bug where `ls -le` would print the time twice.bug12004-01-181-13/+13
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8312 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Use bb_getopt_ulflags, save 200-300 bytesbug12004-01-181-89/+131
| | | | git-svn-id: svn://busybox.net/trunk/busybox@8311 69ca8d6d-28ef-0310-b511-8ec308f3f277
* Patch from Bastian Blank to fix debian bug #226722, test case: bug12004-01-081-12/+1
| | | | | | | | | mkdir foo touch foo/bar ln -s bar foo/baz git-svn-id: svn://busybox.net/trunk/busybox@8266 69ca8d6d-28ef-0310-b511-8ec308f3f277
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-08-10 12:02:09 +0000