From 32df6b575040d023457292a37720e2c9cdb3be77 Mon Sep 17 00:00:00 2001 From: andersen Date: Wed, 5 May 2004 19:39:21 +0000 Subject: Steve Grubb writes: Hi, I just re-reviewed the patch I just sent...and it needed to be BUFSIZ-3 in dos2unix.c . tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. The loop increments by 2. That's why it should be BUFSIZ-3. Best Regards, Steve Grubb git-svn-id: svn://busybox.net/trunk/busybox@8805 69ca8d6d-28ef-0310-b511-8ec308f3f277 --- coreutils/dos2unix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/coreutils/dos2unix.c b/coreutils/dos2unix.c index c8cebcec7..df0b4f977 100644 --- a/coreutils/dos2unix.c +++ b/coreutils/dos2unix.c @@ -64,7 +64,9 @@ static int convert(char *fn, int ConvType) c = strlen(tempFn); tempFn[c] = '.'; while(1) { - if (c >=BUFSIZ-2) + /* tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. + * The loop increments by 2. So this must check for BUFSIZ-3. */ + if (c >=BUFSIZ-3) bb_error_msg_and_die("unique name not found"); /* Get some semi random stuff to try and make a * random filename based (and in the same dir as) -- cgit v1.2.3-55-g6feb