| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
| |
comments and other janitorial work.
|
| |
|
|
|
|
|
|
|
| |
The variable to be closed in a generic 'for' loop now is the
4th value produced in the loop initialization, instead of being
the loop state (the 2nd value produced). That allows a loop to
use a state with a '__toclose' metamethod but do not close it.
(As an example, 'f:lines()' might use the file 'f' as a state
for the loop, but it should not close the file when the loop ends.)
|
| |
|
|
|
|
|
| |
The repetitive code of the arithmetic and bitwise operators in
the main iterpreter loop was moved to appropriate macros.
(As a detail, the function 'luaV_div' was renamed 'luaV_idiv',
as it does an "integer division" (floor division).
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mechanism of "caching the last closure created for a prototype to
try to reuse it the next time a closure for that prototype is created"
was removed. There are several reasons:
- It is hard to find a natural example where this cache has a measurable
impact on performance.
- Programmers already perceive closure creation as something slow,
so they tend to avoid it inside hot paths. (Any case where the cache
could reuse a closure can be rewritten predefining the closure in some
variable and using that variable.)
- The implementation was somewhat complex, due to a bad interaction
with the generational collector. (Typically, new closures are new,
while prototypes are old. So, the cache breaks the invariant that
old objects should not point to new ones.)
|
| |
|
|
|
|
|
|
|
|
|
| |
The implicit variable 'state' in a generic 'for' is marked as a
to-be-closed variable, so that the state will be closed as soon
as the loop ends, no matter how.
Taking advantage of this new facility, the call 'io.lines(filename)'
now returns the open file as a second result. Therefore,
an iteraction like 'for l in io.lines(name)...' will close the
file even when the loop ends with a break or an error.
|
| |
|
|
|
|
| |
"Better" and similar to error messages for invalid function arguments.
*old message: 'for' limit must be a number
*new message: bad 'for' limit (number expected, got table)
|
| |
|
|
|
|
|
| |
Added new instruction 'OP_TFORPREP' to prepare a generic for loop.
Currently it is equivalent to a jump (but with a format 'iABx',
similar to other for-loop preparing instructions), but soon it will
be the place to create upvalues for closing loop states.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
A closing method cannot be called in its own stack slot, as there may
be returning values in the stack after that slot, and the call would
corrupt those values. Instead, the closing method must be copied to the
top of the stack to be called.
Moreover, even when a function returns no value, its return istruction
still has to have its position (which will set the stack top) after
the local variables, otherwise a closing method might corrupt another
not-yet-called closing method.
|
| | |
|
| |
|
|
|
|
|
| |
Still missing:
- handling of memory errors when creating upvalue (must run closing
method all the same)
- interaction with coroutines
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Start of the implementation of "scoped variables" or "to be closed"
variables, local variables whose '__close' (or themselves) are called
when they go out of scope. This commit implements the syntax, the
opcode, and the creation of the corresponding upvalue, but it still
does not call the finalizations when the variable goes out of scope
(the most important part).
Currently, the syntax is 'local scoped name = exp', but that will
probably change.
|
| |
|
|
|
|
|
|
|
| |
The multiplication (m*b) used to test whether 'm' is non-zero and
'm' and 'b' have different signs can underflow for very small numbers,
giving a wrong result. The use of explicit comparisons solves this
problem. This commit also adds several new tests for '%' (both for
floats and for integers) to exercise more corner cases, such as
very large and very small values.
|
| |
|
|
|
|
|
|
|
|
|
| |
As hinted in the manual for Lua 5.3, the emulation of the metamethod
for '__le' using '__le' has been deprecated. It is slow, complicates
the logic, and it is easy to avoid this emulation by defining a proper
'__le' function.
Moreover, often this emulation was used wrongly, with a programmer
assuming that an order is total when it is not (e.g., NaN in
floating-point numbers).
|
| |
|
|
|
| |
Minor optimizations in 'lvm.c'. (Not exactly optimizations, but more
chances for optimizations.)
|
| |
|
|
|
| |
Opocode was using 'luai_numdiv' (float division) instead of
'luai_numidiv' (integer division).
|
| |
|
|
|
|
| |
during any memory allocation +
'luaT_getvarargs' may reallocate the stack, and therefore the top must
be correct.
|
| |
|
|
| |
be used as a hint for '#t'
|
| |
|
|
|
| |
(instead, use a different kind of nil to signal the fake entry returned
when a key is not found in a table)
|
| |
|
|
| |
(used only in errors for now)
|
| | |
|
| |
|
|
| |
(the code is simpler without 'vra' and conversion is a no-op)
|
| | |
|
| | |
|
| |
|
|
| |
call to 'luaT_keydef' must be protected
|
| | |
|
| | |
|
| |
|
|
|
| |
rttype -> rawtt; ttyperaw -> withvariant; ttype -> ttypetag;
tnov -> ttype
|
| |
|
|
| |
(so that, in the future, tables can contain regular nil entries)
|
| |
|
|
| |
(if a jump table is used, the unification may harm jump prediction.)
|
| | |
|
| |
|
|
| |
+ 'LTfloatint'/'LEfloatint'
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
new implementation should have zero overhead for non-vararg functions
|
| |
|
|
| |
(avoids test for vararg function in all function calls)
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
(instead of waiting for following 'OP_RETURN')
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
(plus exchanged parameters of OP_VARARG to make it similar to other
'isOT' instructions)
|
| |
|
|
| |
set it only when needed.
|
| |
|
|
| |
(allocation errors do not call message handlers)
|
| |
|
|
| |
with increment of 1)
|
| |
|
|
|
| |
because, too often, masks in bitwise operations are integers larger
than one byte.)
|
